javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(core): avoid setting the same value to view properties (#10602)

Browse Source
This commit is contained in:
Dimitris-Rafail Katsampas
2024-08-08 03:28:15 +03:00
committed by GitHub
parent 75c8e941a0
commit 499fe8dc82
1 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/core/ui/styling/style-scope.ts
View File

@ -721,26 +721,41 @@ export class CssState {
cssExpsProperties[property] = value; cssExpsProperties[property] = value;
continue; continue;
} }
if (property in oldProperties) {
const oldValue = oldProperties[property];
delete oldProperties[property]; delete oldProperties[property];
if (property in oldProperties && oldProperties[property] === value) {
if (oldValue === value) {
// Skip unchanged values // Skip unchanged values
continue; continue;
} }
}
if (isCssVariable(property)) { if (isCssVariable(property)) {
view.style.setScopedCssVariable(property, value); view.style.setScopedCssVariable(property, value);
delete newPropertyValues[property]; delete newPropertyValues[property];
continue; continue;
} }
valuesToApply[property] = value; valuesToApply[property] = value;
} }
//we need to parse CSS vars first before evaluating css expressions
// we need to parse CSS vars first before evaluating css expressions
for (const property in cssExpsProperties) { for (const property in cssExpsProperties) {
delete oldProperties[property];
const value = evaluateCssExpressions(view, property, cssExpsProperties[property]); const value = evaluateCssExpressions(view, property, cssExpsProperties[property]);
if (property in oldProperties && oldProperties[property] === value) {
if (property in oldProperties) {
const oldValue = oldProperties[property];
delete oldProperties[property];
if (oldValue === value) {
// Skip unchanged values // Skip unchanged values
continue; continue;
} }
}
if (value === unsetValue) { if (value === unsetValue) {
delete newPropertyValues[property]; delete newPropertyValues[property];
} }
@ -761,9 +776,11 @@ export class CssState {
view[camelCasedProperty] = unsetValue; view[camelCasedProperty] = unsetValue;
} }
} }
// Set new values to the style // Set new values to the style
for (const property in valuesToApply) { for (const property in valuesToApply) {
const value = valuesToApply[property]; const value = valuesToApply[property];
try { try {
if (property in view.style) { if (property in view.style) {
view.style[`css:${property}`] = value; view.style[`css:${property}`] = value;