javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 12:57:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent stack overflow when re-applying iOS formatted text after a style property changes

Browse Source 
Related to #1078
This commit is contained in:
Rossen Hristov
2016-03-16 09:39:06 +02:00
parent de8b6d85a9
commit 48704f19f9
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ui/text-base/text-base.ios.ts
View File

@ -17,11 +17,19 @@ export class TextBase extends common.TextBase {
this.requestLayout(); this.requestLayout();
} }
private _settingFormattedTextPropertyToNative = false;
public _onStylePropertyChanged(property: dependencyObservable.Property): void { public _onStylePropertyChanged(property: dependencyObservable.Property): void {
if (this._settingFormattedTextPropertyToNative) {
// Guard against stack-overflow.
return;
}
if (this.formattedText) { if (this.formattedText) {
// Re-apply the formatted text to override style changes if needed. // Re-apply the formatted text to override style changes if needed.
// https://github.com/NativeScript/NativeScript/issues/1078 // https://github.com/NativeScript/NativeScript/issues/1078
this._settingFormattedTextPropertyToNative = true;
this._setFormattedTextPropertyToNative(this.formattedText); this._setFormattedTextPropertyToNative(this.formattedText);
this._settingFormattedTextPropertyToNative = false;
} }
} }
} }