javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(time-picker): properly handle 0 on hour and minutes with valueChanged (#10460)

Browse Source 
closes https://github.com/NativeScript/NativeScript/issues/10457
This commit is contained in:
Nathan Walker
2023-12-17 15:17:32 -08:00
committed by GitHub
parent 82e9c67d33
commit 4762699fa1
4 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/ui/time-picker/time-picker-common.ts
View File

@@ -165,8 +165,11 @@ minuteIntervalProperty.register(TimePickerBase);
export const minuteProperty = new Property<TimePickerBase, number>({
name: 'minute',
defaultValue: 0,
// avoid defaultValue of 0 because it will prevent valueChanged from firing to initialize value due to it already matching defaultValue to start
// sometimes user needs to set 0: https://github.com/NativeScript/NativeScript/issues/10457
defaultValue: null,
valueChanged: (picker, oldValue, newValue) => {
newValue = newValue || 0;
if (!isMinuteValid(newValue) || !isValidTime(picker)) {
throw new Error(getErrorMessage(picker, 'minute', newValue));
}
@@ -179,8 +182,11 @@ minuteProperty.register(TimePickerBase);
export const hourProperty = new Property<TimePickerBase, number>({
name: 'hour',
defaultValue: 0,
// avoid defaultValue of 0 because it will prevent valueChanged from firing to initialize value due to it already matching defaultValue to start
// sometimes user needs to set 0: https://github.com/NativeScript/NativeScript/issues/10457
defaultValue: null,
valueChanged: (picker, oldValue, newValue) => {
newValue = newValue || 0;
if (!isHourValid(newValue) || !isValidTime(picker)) {
throw new Error(getErrorMessage(picker, 'Hour', newValue));
}