javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 11:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): second livesync (#6330)

Browse Source
This commit is contained in:
Manol Donev
2018-10-04 15:57:11 +03:00
committed by GitHub
parent 0bf6dc2e93
commit 436a318de5
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tns-core-modules/ui/frame/fragment.transitions.android.ts
View File

@ -721,15 +721,6 @@ function toShortString(nativeTransition: android.transition.Transition): string
return `${nativeTransition.getClass().getSimpleName()}@${nativeTransition.hashCode().toString(16)}`; return `${nativeTransition.getClass().getSimpleName()}@${nativeTransition.hashCode().toString(16)}`;
} }
function createDummyZeroDurationAnimation(): android.view.animation.Animation {
// NOTE: returning the dummy AlphaAnimation directly does not work for some reason;
// animationEnd is fired first, then some animationStart (but for a different animation?)
const animationSet = new android.view.animation.AnimationSet(false);
animationSet.addAnimation(new android.view.animation.AlphaAnimation(1, 1));
return animationSet;
}
function printTransitions(entry: ExpandedEntry) { function printTransitions(entry: ExpandedEntry) {
if (entry && traceEnabled()) { if (entry && traceEnabled()) {
let result = `${entry.fragmentTag} Transitions:`; let result = `${entry.fragmentTag} Transitions:`;
@ -756,6 +747,14 @@ function printTransitions(entry: ExpandedEntry) {
class NoTransition extends Transition { class NoTransition extends Transition {
public createAndroidAnimation(transitionType: string): android.view.animation.Animation { public createAndroidAnimation(transitionType: string): android.view.animation.Animation {
return createDummyZeroDurationAnimation(); const animation = new android.view.animation.AlphaAnimation(1, 1);
// NOTE: this should not be necessary when we revert to Animators API
// HACK: Android view animation with zero duration seems to be buggy and raises animation listener events in illogical (wrong?) order:
// "enter" start -> "enter" end -> "exit" start -> "exit" end;
// we would expect events to overlap "exit" start -> "enter" start -> "exit" end -> "enter" end, or at least
// "exit" start / end to be raised before "enter" start / end
animation.setDuration(1);
return animation;
} }
} }