javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 04:41:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(ios): textfield option to disable iOS autofill strong password handling (#8348)

Browse Source 
* feat(ios): textfield option to disable autofill strong password handling

* chore: api change report
This commit is contained in:
Nathan Walker
2020-03-23 03:16:40 -07:00
committed by GitHub
parent 8ab0e72bc9
commit 42fc4acea3
4 changed files with 80 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
api-reports/NativeScript.api.md
View File

@ -2424,10 +2424,9 @@ export class TabViewItem extends ViewBase {
// @public // @public
export interface TapGestureEventData extends GestureEventData { export interface TapGestureEventData extends GestureEventData {
getPointerCount(): number; getPointerCount(): number;
getX(): number; getX(): number;
getY(): number; getY(): number;
} }
// @public // @public
@ -2508,6 +2507,8 @@ export class TextField extends EditableTextBase {
public static returnPressEvent: string; public static returnPressEvent: string;
secure: boolean; secure: boolean;
secureWithoutAutofill: boolean;
} }
// @public // @public

2
nativescript-core/ui/text-field/text-field-common.ts
View File

@ -8,6 +8,8 @@ export class TextFieldBase extends EditableTextBase implements TextFieldDefiniti
public static returnPressEvent = "returnPress"; public static returnPressEvent = "returnPress";
public secure: boolean; public secure: boolean;
public closeOnReturn: boolean; public closeOnReturn: boolean;
// iOS only (to avoid 12+ suggested strong password handling)
public secureWithoutAutofill: boolean;
} }
TextFieldBase.prototype.recycleNativeView = "auto"; TextFieldBase.prototype.recycleNativeView = "auto";

5
nativescript-core/ui/text-field/text-field.d.ts vendored
View File

@ -32,4 +32,9 @@ export class TextField extends EditableTextBase {
* Gets or sets if a text field should dismiss on return. * Gets or sets if a text field should dismiss on return.
*/ */
closeOnReturn: boolean; closeOnReturn: boolean;
/**
* iOS only (to avoid 12+ auto suggested strong password handling)
*/
secureWithoutAutofill: boolean;
} }

8
nativescript-core/ui/text-field/text-field.ios.ts
View File

@ -78,6 +78,14 @@ class UITextFieldDelegateImpl extends NSObject implements UITextFieldDelegate {
public textFieldShouldChangeCharactersInRangeReplacementString(textField: UITextField, range: NSRange, replacementString: string): boolean { public textFieldShouldChangeCharactersInRangeReplacementString(textField: UITextField, range: NSRange, replacementString: string): boolean {
const owner = this._owner.get(); const owner = this._owner.get();
if (owner) { if (owner) {
if (owner.secureWithoutAutofill && !textField.secureTextEntry) {
/**
* Helps avoid iOS 12+ autofill strong password suggestion prompt
* Discussed in several circles but for example:
* https://github.com/expo/expo/issues/2571#issuecomment-473347380
*/
textField.secureTextEntry = true;
}
const delta = replacementString.length - range.length; const delta = replacementString.length - range.length;
if (delta > 0) { if (delta > 0) {
if (textField.text.length + delta > owner.maxLength) { if (textField.text.length + delta > owner.maxLength) {