javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(webpack): prevent hmr from patching __onLiveSync multiple times (#10103)

Browse Source
This commit is contained in:
Eduardo Speroni
2022-11-24 08:18:51 -03:00
committed by GitHub
parent cfaa8134b0
commit 42f5dc51c7
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/webpack5/src/loaders/nativescript-hot-loader/hmr.runtime.ts
View File

@ -6,6 +6,8 @@
if (module.hot) { if (module.hot) {
let hash = __webpack_require__.h(); let hash = __webpack_require__.h();
let hmrBootEmittedSymbol = Symbol.for('HMRBootEmitted'); let hmrBootEmittedSymbol = Symbol.for('HMRBootEmitted');
let originalLiveSyncSymbol = Symbol.for('OriginalLiveSync');
let hmrRuntimeLastLiveSyncSymbol = Symbol.for('HMRRuntimeLastLiveSync');
const logVerbose = (title: string, ...info: any) => { const logVerbose = (title: string, ...info: any) => {
if (__NS_ENV_VERBOSE__) { if (__NS_ENV_VERBOSE__) {
@ -108,8 +110,12 @@ if (module.hot) {
].some((path) => requireExists(path)); ].some((path) => requireExists(path));
}; };
const originalOnLiveSync = global.__onLiveSync; if (global.__onLiveSync !== global[hmrRuntimeLastLiveSyncSymbol]) {
global.__onLiveSync = async function () { // we store the original liveSync here in case this code runs again
// which happens when you module.hot.accept() the main file
global[originalLiveSyncSymbol] = global.__onLiveSync;
}
global[hmrRuntimeLastLiveSyncSymbol] = async function () {
logVerbose('LiveSync'); logVerbose('LiveSync');
if (!hasUpdate()) { if (!hasUpdate()) {
@ -120,9 +126,10 @@ if (module.hot) {
return false; return false;
} }
await originalOnLiveSync(); await global[originalLiveSyncSymbol]();
}; };
global.__onLiveSync = global[hmrRuntimeLastLiveSyncSymbol];
if (!global[hmrBootEmittedSymbol]) { if (!global[hmrBootEmittedSymbol]) {
global[hmrBootEmittedSymbol] = true; global[hmrBootEmittedSymbol] = true;
setStatus(hash, 'boot', 'HMR Enabled - waiting for changes...'); setStatus(hash, 'boot', 'HMR Enabled - waiting for changes...');