javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 03:31:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Observable array now fires property change for length property.

Browse Source
This commit is contained in:
Nedyalko Nikolov
2015-03-05 14:54:46 +02:00
parent b04d1fcd3a
commit 4152e66195
7 changed files with 125 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
data/observable-array/observable-array.ts
View File

@ -88,13 +88,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
*/
concat(): T[] {
this._addArgs.index = this._array.length;
var result = this._array.concat.apply(this._array, arguments);
this._addArgs.addedCount = result.length - this._array.length;
this.notify(this._addArgs);
return result;
}
@ -117,6 +111,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
this._deleteArgs.removed = [result];
this.notify(this._deleteArgs);
this._notifyLengthChange();
return result;
}
@ -143,10 +138,16 @@ export class ObservableArray<T> extends observable.Observable implements observa
this._addArgs.addedCount = this._array.length - this._addArgs.index;
this.notify(this._addArgs);
this._notifyLengthChange();
return this._array.length;
}
_notifyLengthChange() {
var lengthChangedData = this._createPropertyChangeData("length", this._array.length);
this.notify(lengthChangedData);
}
/**
* Reverses the elements in an Array.
*/
@ -164,6 +165,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
this._deleteArgs.removed = [result];
this.notify(this._deleteArgs);
this._notifyLengthChange();
return result;
}
@ -202,6 +204,9 @@ export class ObservableArray<T> extends observable.Observable implements observa
removed: result,
addedCount: this._array.length > length ? this._array.length - length : 0
});
if (this._array.length !== length) {
this._notifyLengthChange();
}
return result;
}
@ -218,6 +223,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
this._addArgs.addedCount = result - length;
this.notify(this._addArgs);
this._notifyLengthChange();
return result;
}