From 4039e2c86eb8a129ca41b0c41ab944ce146e27c7 Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Sat, 5 Jul 2025 22:20:31 -0700 Subject: [PATCH] chore: use esm with hooks --- packages/core/cli-hooks/before-checkForChanges.js | 12 ++++++------ packages/core/cli-hooks/postinstall.js | 9 +++++++-- packages/core/cli-hooks/preuninstall.js | 9 +++++++-- 3 files changed, 20 insertions(+), 10 deletions(-) diff --git a/packages/core/cli-hooks/before-checkForChanges.js b/packages/core/cli-hooks/before-checkForChanges.js index 79f5be491..207a679b6 100644 --- a/packages/core/cli-hooks/before-checkForChanges.js +++ b/packages/core/cli-hooks/before-checkForChanges.js @@ -1,15 +1,15 @@ -const semver = require("semver"); +import semver from 'semver'; const webpackPackageName = "@nativescript/webpack"; -module.exports = function ($staticConfig, hookArgs) { +export default function ($staticConfig, hookArgs) { const cliVersion = semver.parse($staticConfig.version); - const platfrom = hookArgs.prepareData.platform; + const platform = hookArgs.prepareData.platform; const projectData = hookArgs.projectData; // Required CLI version for building IOS: 6.2.0 - if (platfrom.toLowerCase() === "ios" && - !satisfiesRequriredVersion(cliVersion, 6, 2)) { + if (platform.toLowerCase() === "ios" && + !satisfiesRequiredVersion(cliVersion, 6, 2)) { throw new Error(`Building @nativescript/core for iOS requires NativeScript CLI with version at least 6.2.0. Please upgrade your NativeScript CLI version (npm i -g nativescript).`); } @@ -26,7 +26,7 @@ module.exports = function ($staticConfig, hookArgs) { /** * Checks if semver object satisifies a major/minor requirement. Pre-release versions are OK too! */ -function satisfiesRequriredVersion(actualVersion, requiredMajor, requiredMinor) { +function satisfiesRequiredVersion(actualVersion, requiredMajor, requiredMinor) { // Return true for null version to handle tags (ex. "next", "rc") if (!actualVersion) { return true; diff --git a/packages/core/cli-hooks/postinstall.js b/packages/core/cli-hooks/postinstall.js index 01b05b46a..a3bd4c6c7 100644 --- a/packages/core/cli-hooks/postinstall.js +++ b/packages/core/cli-hooks/postinstall.js @@ -1,2 +1,7 @@ -const path = require('path'); -require('@nativescript/hook')(path.join(__dirname, "..")).postinstall(); \ No newline at end of file +import path from 'path'; +import hook from '@nativescript/hook'; +import { fileURLToPath } from "url"; + +const __filename = fileURLToPath(import.meta.url); +const __dirname = path.dirname(__filename); +hook(path.join(__dirname, "..")).postinstall(); \ No newline at end of file diff --git a/packages/core/cli-hooks/preuninstall.js b/packages/core/cli-hooks/preuninstall.js index 90f31ba7d..8fa234303 100644 --- a/packages/core/cli-hooks/preuninstall.js +++ b/packages/core/cli-hooks/preuninstall.js @@ -1,2 +1,7 @@ -const path = require('path'); -require('@nativescript/hook')(path.join(__dirname, "..")).preuninstall(); \ No newline at end of file +import path from 'path'; +import hook from '@nativescript/hook'; +import { fileURLToPath } from "url"; + +const __filename = fileURLToPath(import.meta.url); +const __dirname = path.dirname(__filename); +hook(path.join(__dirname, "..")).preuninstall(); \ No newline at end of file