From 3e61b37f4db675f95face314c9849fdb54209377 Mon Sep 17 00:00:00 2001 From: Stanimir Karoserov Date: Tue, 27 May 2014 16:42:50 +0300 Subject: [PATCH] BCL: updated camera for iOS and camera definitions --- camera/Readme.md | 11 +++++++++++ camera/camera-types.ts | 2 +- camera/camera.d.ts | 11 ++++++----- camera/camera.ios.ts | 18 ++++++++++++++++++ 4 files changed, 36 insertions(+), 6 deletions(-) create mode 100644 camera/Readme.md diff --git a/camera/Readme.md b/camera/Readme.md new file mode 100644 index 000000000..582581ad9 --- /dev/null +++ b/camera/Readme.md @@ -0,0 +1,11 @@ +Sample usage: +``` +var camera = require("camera"); + +camera.takePicture({"cameraPosition": camera.CameraPosition.BACK, "flashMode": camera.FlashMode.ON}).then(function (image) { + console.log('pic taken - width: ' + image.width + ", height: " + image.height); +}).fail(function (error) { + console.log('pic canceled'); +}); + +``` diff --git a/camera/camera-types.ts b/camera/camera-types.ts index 565425d94..426285f54 100644 --- a/camera/camera-types.ts +++ b/camera/camera-types.ts @@ -5,9 +5,9 @@ export enum CameraPosition { } export enum FlashMode { + OFF = -1, AUTO = 0, // default ON = 1, - OFF = 2 } export interface Options { diff --git a/camera/camera.d.ts b/camera/camera.d.ts index bda4fdb8d..84697d99b 100644 --- a/camera/camera.d.ts +++ b/camera/camera.d.ts @@ -23,6 +23,10 @@ declare module "camera" { * Specifies a camera flash mode. */ enum FlashMode { + /** + * The camera flash is disabled. + */ + OFF = -1, /** * Flash will be fired automatically when required. */ @@ -31,14 +35,10 @@ declare module "camera" { * The camera flash is enabled. */ ON = 1, - /** - * The camera flash is disabled. - */ - OFF = 2 } /** - * Camera options for capture an image. + * Camera options for capture an image. Currently not guaranteed to be used on Android */ interface Options { /** @@ -55,6 +55,7 @@ declare module "camera" { // TODO most of hardware related parts need to handle onPause and onResume of the calling activities /** + * TODO replace it with promise methods only and remove this class * This class provides access to the device camera and photo libraries. */ class CameraManager { diff --git a/camera/camera.ios.ts b/camera/camera.ios.ts index a9058779e..9ae528002 100644 --- a/camera/camera.ios.ts +++ b/camera/camera.ios.ts @@ -2,6 +2,11 @@ import imageSource = require("image-source"); import types = require("camera/camera-types"); +// merge the exports of the types module with the exports of this file +import merger = require("utils/module-merge"); +declare var exports; +merger.merge(types, exports); + var imagePickerController; export class CameraManager { @@ -69,6 +74,19 @@ export var takePicture = function (options?: types.Options): promises.Promise