From 3cb2d8a9155b615f667cb5612104f6202cea6cc5 Mon Sep 17 00:00:00 2001 From: Rossen Hristov Date: Tue, 13 Oct 2015 17:03:39 +0300 Subject: [PATCH] Playing with the unit test in order to blind-fix it for the PR build. --- apps/tests/ui/scroll-view/scroll-view-tests.ts | 4 +++- apps/tests/ui/tab-view/tab-view-tests.ts | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/apps/tests/ui/scroll-view/scroll-view-tests.ts b/apps/tests/ui/scroll-view/scroll-view-tests.ts index d4972357a..b7b13f395 100644 --- a/apps/tests/ui/scroll-view/scroll-view-tests.ts +++ b/apps/tests/ui/scroll-view/scroll-view-tests.ts @@ -236,7 +236,9 @@ export function test_scrollToHorizontalOffset_with_animation() { // No synchronous change. TKUnit.assertEqual(scrollView.horizontalOffset, 0, "scrollView.horizontalOffset"); - TKUnit.waitUntilReady(() => { return scrollView.horizontalOffset === 100 }, ASYNC); + //For some reason this wait here causes the test to fail on PR builds. + //TKUnit.waitUntilReady(() => { return scrollView.horizontalOffset === 100 }, ASYNC); + TKUnit.wait(1); // The scrolling animation should be finished by now TKUnit.assertAreClose(scrollView.horizontalOffset, 100, 0.1, "scrollView.horizontalOffset"); diff --git a/apps/tests/ui/tab-view/tab-view-tests.ts b/apps/tests/ui/tab-view/tab-view-tests.ts index 0c3901a2d..89d1f9210 100644 --- a/apps/tests/ui/tab-view/tab-view-tests.ts +++ b/apps/tests/ui/tab-view/tab-view-tests.ts @@ -544,11 +544,13 @@ function testLoadedAndUnloadedAreFired_WhenNavigatingAwayAndBack(enablePageCache // Go back to the test page. helper.goBack(); } + + //For some reason this wait here causes the test to fail on PR builds. //TKUnit.waitUntilReady(() => { return items[0].view.isLoaded; }, ASYNC); TKUnit.wait(1); - console.log(">>>>>>>>>>>>> loaded items: " + loadedItems.join(", ")); - console.log(">>>>>>>>>>>>> unloadedItems items: " + unloadedItems.join(", ")); + //console.log(">>>>>>>>>>>>> loaded items: " + loadedItems.join(", ")); + //console.log(">>>>>>>>>>>>> unloadedItems items: " + unloadedItems.join(", ")); // Check that at least the first item is loaded and unloaded TKUnit.assert(items[0].view.isLoaded, "The content of the first tab should be loaded.");