javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 11:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(webpack): drop custom flavor helper & explicitly set in each config

Browse Source
This commit is contained in:
Igor Randjelovic
2021-08-29 18:08:05 +02:00
committed by Nathan Walker
parent 5452b89735
commit 3bdc34aec3
15 changed files with 63 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/webpack5/src/configuration/angular.ts
View File

@ -1,4 +1,5 @@
import { extname, resolve } from 'path';
import { merge } from 'webpack-merge';
import Config from 'webpack-chain';
import { existsSync } from 'fs';
@ -222,6 +223,14 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
])
);
config.plugin('DefinePlugin').tap((args) => {
args[0] = merge(args[0], {
__UI_USE_EXTERNAL_RENDERER__: true,
});
return args;
});
return config;
}

3
packages/webpack5/src/configuration/base.ts
View File

@ -15,7 +15,6 @@ import { applyFileReplacements } from '../helpers/fileReplacements';
import { addCopyRule, applyCopyRules } from '../helpers/copyRules';
import { WatchStatePlugin } from '../plugins/WatchStatePlugin';
import { getProjectFilePath } from '../helpers/project';
import { projectUsesCustomFlavor } from '../helpers/flavor';
import { hasDependency } from '../helpers/dependencies';
import { applyDotEnvPlugin } from '../helpers/dotEnv';
import { env as _env, IWebpackEnv } from '../index';
@ -354,7 +353,7 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
mode === 'development' ? JSON.stringify(getIPS()) : `[]`,
__CSS_PARSER__: JSON.stringify(getValue('cssParser', 'css-tree')),
__UI_USE_XML_PARSER__: true,
__UI_USE_EXTERNAL_RENDERER__: projectUsesCustomFlavor(),
__UI_USE_EXTERNAL_RENDERER__: false,
__ANDROID__: platform === 'android',
__IOS__: platform === 'ios',
/* for compat only */ 'global.isAndroid': platform === 'android',

1
packages/webpack5/src/configuration/react.ts
View File

@ -26,6 +26,7 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
args[0] = merge(args[0], {
/** For various libraries in the React ecosystem. */
__TEST__: false,
__UI_USE_EXTERNAL_RENDERER__: true,
/**
* Primarily for React Fast Refresh plugin, but technically the allowHmrInProduction option could be used instead.
* Worth including anyway, as there are plenty of Node libraries that use this flag.

11
packages/webpack5/src/configuration/svelte.ts
View File

@ -1,11 +1,12 @@
import { merge } from 'webpack-merge';
import Config from 'webpack-chain';
import { getProjectFilePath } from '../helpers/project';
import { hasDependency } from '../helpers/dependencies';
import { getPlatformName } from '../helpers/platform';
import { env as _env, IWebpackEnv } from '../index';
import { error } from '../helpers/log';
import base from './base';
import { hasDependency } from '../helpers/dependencies';
export default function (config: Config, env: IWebpackEnv = _env): Config {
base(config, env);
@ -84,6 +85,14 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
});
}
config.plugin('DefinePlugin').tap((args) => {
args[0] = merge(args[0], {
__UI_USE_EXTERNAL_RENDERER__: true,
});
return args;
});
return config;
}

8
packages/webpack5/src/configuration/vue.ts
View File

@ -88,6 +88,14 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
// add an alias for vue, since some plugins may try to import it
config.resolve.alias.set('vue', 'nativescript-vue');
config.plugin('DefinePlugin').tap((args) => {
args[0] = merge(args[0], {
__UI_USE_EXTERNAL_RENDERER__: true,
});
return args;
});
return config;
}