javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 11:01:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf: disable accessibility for layout views (#10482)

Browse Source 
a11y is enabled by default on controls still, this just disables on layouts alone as unnecessary.
It can be enabled on a per layout view basis if needed anytime.
This commit is contained in:
farfromrefuge
2024-02-10 18:25:04 +00:00
committed by GitHub
parent d34a4395ec
commit 3bd6d9b01e
6 changed files with 25 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/core/accessibility/accessibility-properties.ts
View File

@ -26,6 +26,7 @@ function makePropertyEnumConverter<T>(enumValues) {
export const accessibilityEnabledProperty = new CssProperty<Style, boolean>({
name: 'accessible',
defaultValue: true,
cssName: 'a11y-enabled',
valueConverter: booleanConverter,
});

2
packages/core/ui/core/view-base/index.ts
View File

@ -2,7 +2,6 @@ import { AlignSelf, FlexGrow, FlexShrink, FlexWrapBefore, Order } from '../../la
import { Page } from '../../page';
import { CoreTypes } from '../../../core-types';
import { Property, CssProperty, CssAnimationProperty, InheritedProperty, clearInheritedProperties, propagateInheritableProperties, propagateInheritableCssProperties, initNativeView } from '../properties';
import { setupAccessibleView } from '../../../accessibility';
import { CSSUtils } from '../../../css/system-classes';
import { Source } from '../../../utils/debug';
import { Binding, BindingOptions } from '../bindable';
@ -599,7 +598,6 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition
return true;
});
setupAccessibleView(<any>this);
this._emit('loaded');
}

14
packages/core/ui/core/view/index.android.ts
View File

@ -820,8 +820,9 @@ export class View extends ViewCommon {
[accessibilityEnabledProperty.setNative](value: boolean): void {
this.nativeViewProtected.setFocusable(!!value);
updateAccessibilityProperties(this);
if (value) {
updateAccessibilityProperties(this);
}
}
[accessibilityIdentifierProperty.setNative](value: string): void {
@ -1257,6 +1258,15 @@ export class View extends ViewCommon {
export class ContainerView extends View {
public iosOverflowSafeArea: boolean;
constructor() {
super();
/**
* mark accessible as false without triggering proerty change
* equivalent to changing the default
*/
this.style[accessibilityEnabledProperty.key] = false;
}
}
export class CustomLayoutView extends ContainerView implements CustomLayoutViewDefinition {

5
packages/core/ui/core/view/index.d.ts vendored
View File

@ -228,11 +228,6 @@ export abstract class View extends ViewCommon {
*/
color: Color;
/**
* If `true` the element is an accessibility element and all the children will be treated as a single selectable component.
*/
accessible: boolean;
/**
* Hide the view and its children from the a11y service
*/

10
packages/core/ui/core/view/index.ios.ts
View File

@ -677,8 +677,9 @@ export class View extends ViewCommon implements ViewDefinition {
[accessibilityEnabledProperty.setNative](value: boolean): void {
this.nativeViewProtected.isAccessibilityElement = !!value;
updateAccessibilityProperties(this);
if (value) {
updateAccessibilityProperties(this);
}
}
[accessibilityIdentifierProperty.getDefault](): string {
@ -1062,6 +1063,11 @@ export class ContainerView extends View {
constructor() {
super();
this.iosOverflowSafeArea = true;
/**
* mark accessible as false without triggering proerty change
* equivalent to changing the default
*/
this.style[accessibilityEnabledProperty.key] = false;
}
}

6
packages/core/ui/core/view/view-common.ts
View File

@ -12,6 +12,7 @@ import { EventData } from '../../../data/observable';
import { Trace } from '../../../trace';
import { CoreTypes } from '../../../core-types';
import { ViewHelper } from './view-helper';
import { setupAccessibleView } from '../../../accessibility';
import { PercentLength } from '../../styling/style-properties';
@ -177,6 +178,9 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {
}
}
super.onLoaded();
if (this.accessible) {
setupAccessibleView(this);
}
}
public _closeAllModalViewsInternal(): boolean {
@ -810,11 +814,9 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {
get accessible(): boolean {
return this.style.accessible;
// return this._accessible;
}
set accessible(value: boolean) {
this.style.accessible = value;
// this._accessible = value;
}
get accessibilityHidden(): boolean {