chore: organize imports

This commit is contained in:
Igor Randjelovic
2020-11-23 15:25:39 +01:00
parent 30c31a252b
commit 31d560f75b
6 changed files with 24 additions and 23 deletions

View File

@ -1,7 +1,8 @@
import base from './base';
import { IWebpackEnv } from '@nativescript/webpack';
import Config from 'webpack-chain'; import Config from 'webpack-chain';
import { IWebpackEnv } from '../index';
import base from './base';
export default function (config: Config, env: IWebpackEnv): Config { export default function (config: Config, env: IWebpackEnv): Config {
base(config, env); base(config, env);

View File

@ -1,13 +1,6 @@
import Config from 'webpack-chain';
import { IWebpackEnv } from '../index';
import {
getAbsoluteDistPath,
getEntryPath,
getPlatform,
getProjectRootPath,
} from '../helpers/project';
import { DefinePlugin, HotModuleReplacementPlugin } from 'webpack'; import { DefinePlugin, HotModuleReplacementPlugin } from 'webpack';
import Config from 'webpack-chain';
import path from 'path';
import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer'; import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer';
import { CleanWebpackPlugin } from 'clean-webpack-plugin'; import { CleanWebpackPlugin } from 'clean-webpack-plugin';
@ -16,7 +9,12 @@ import TerserPlugin from 'terser-webpack-plugin';
// import { WatchStateLoggerPlugin } from '../plugins/WatchStateLoggerPlugin'; // import { WatchStateLoggerPlugin } from '../plugins/WatchStateLoggerPlugin';
import { WatchStatePlugin } from '../plugins/WatchStatePlugin'; import { WatchStatePlugin } from '../plugins/WatchStatePlugin';
import path from 'path'; import { IWebpackEnv } from '../index';
import {
getAbsoluteDistPath,
getEntryPath,
getPlatform,
} from '../helpers/project';
export default function (config: Config, env: IWebpackEnv): Config { export default function (config: Config, env: IWebpackEnv): Config {
const entryPath = getEntryPath(); const entryPath = getEntryPath();
@ -199,9 +197,6 @@ export default function (config: Config, env: IWebpackEnv): Config {
}, },
]); ]);
// todo: we should probably move away from CopyWebpackPlugin
// it has many issues we can solve by simply copying files **before** the build even starts
// this is just a temp inline plugin that does nothing while building out the configs.
const copyPaths = ['assets/**', 'fonts/**', '**/*.+(jpg|png)']; const copyPaths = ['assets/**', 'fonts/**', '**/*.+(jpg|png)'];
config.plugin('CopyWebpackPlugin').use(CopyWebpackPlugin, [ config.plugin('CopyWebpackPlugin').use(CopyWebpackPlugin, [
{ {
@ -211,6 +206,7 @@ export default function (config: Config, env: IWebpackEnv): Config {
noErrorOnMissing: true, noErrorOnMissing: true,
globOptions: { globOptions: {
dot: false, dot: false,
// todo: ignore AppResources if inside app folder!
// ignore: [``] // ignore: [``]
}, },
})), })),

View File

@ -1,7 +1,8 @@
import base from './base';
import { IWebpackEnv } from '@nativescript/webpack';
import Config from 'webpack-chain'; import Config from 'webpack-chain';
import { IWebpackEnv } from '../index';
import base from './base';
// todo: add base configuration for core with javascript // todo: add base configuration for core with javascript
export default function (config: Config, env: IWebpackEnv): Config { export default function (config: Config, env: IWebpackEnv): Config {
base(config, env); base(config, env);

View File

@ -1,8 +1,9 @@
import base from './base';
import { env as _env, IWebpackEnv } from '@nativescript/webpack';
import Config from 'webpack-chain';
import { merge } from 'webpack-merge'; import { merge } from 'webpack-merge';
import Config from 'webpack-chain';
import { env as _env, IWebpackEnv } from '../index';
import { getPlatform } from '../helpers/project'; import { getPlatform } from '../helpers/project';
import base from './base';
export default function (config: Config, env: IWebpackEnv = _env): Config { export default function (config: Config, env: IWebpackEnv = _env): Config {
base(config, env); base(config, env);

View File

@ -1,7 +1,8 @@
import base from './base';
import { IWebpackEnv } from '@nativescript/webpack';
import Config from 'webpack-chain'; import Config from 'webpack-chain';
import { IWebpackEnv } from '../index';
import base from './base';
// todo: add base configuration for core // todo: add base configuration for core
export default function (config: Config, env: IWebpackEnv): Config { export default function (config: Config, env: IWebpackEnv): Config {
base(config, env); base(config, env);

View File

@ -1,9 +1,10 @@
import { VueLoaderPlugin } from 'vue-loader'; import { VueLoaderPlugin } from 'vue-loader';
import { merge } from 'webpack-merge'; import { merge } from 'webpack-merge';
import Config from 'webpack-chain'; import Config from 'webpack-chain';
import base from './base';
import { env as _env, IWebpackEnv } from '../index'; import { env as _env, IWebpackEnv } from '../index';
import { getPlatform } from '../helpers/project'; import { getPlatform } from '../helpers/project';
import base from './base';
export default function (config: Config, env: IWebpackEnv = _env): Config { export default function (config: Config, env: IWebpackEnv = _env): Config {
base(config, env); base(config, env);