javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix setting text property to number. (#3449)

Browse Source 
Fix setting JS property from native.
This commit is contained in:
Hristo Hristov
2017-01-09 18:13:31 +02:00
committed by GitHub
parent e3acdcbc78
commit 309ea148e1
23 changed files with 156 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tns-core-modules/ui/text-base/text-base-common.ts
View File

@@ -94,7 +94,7 @@ export abstract class TextBaseCommon extends View implements TextBaseDefinition,
public onFormattedTextChanged(data: PropertyChangeData) {
let value = data.value;
this._setFormattedTextPropertyToNative(value);
this.nativePropertyChanged(textProperty, value.toString());
textProperty.nativeValueChange(this, value.toString());
}
public _addChildFromBuilder(name: string, value: any): void {

7
tns-core-modules/ui/text-base/text-base.android.ts
View File

@@ -22,11 +22,8 @@ export class TextBase extends TextBaseCommon {
return this._nativeView.getText();
}
set [textProperty.native](value: string) {
if (value === null || value === undefined) {
value = "";
}
this._nativeView.setText(value);
const text = (value === null || value === undefined) ? '' : value.toString();
this._nativeView.setText(text);
}
//FormattedText

2
tns-core-modules/ui/text-base/text-base.ios.ts
View File

@@ -21,7 +21,7 @@ export class TextBase extends TextBaseCommon {
}
}
set [textProperty.native](value: string) {
let newValue = (typeof value === "undefined") || (value === null) ? "" : value + "";
let newValue = (value === undefined || value === null) ? '' : value.toString();
let nativeView = this.nativeView;
if (nativeView instanceof UIButton) {
nativeView.setTitleForState(newValue, UIControlState.Normal);