javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 04:41:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #825 from NativeScript/segmented-bar-event

Browse Source 
segmented bar selectedIndexChanged fix
This commit is contained in:
Vladimir Enchev
2015-09-25 16:42:27 +03:00
parent b3f2e0ba8b 9e07a2344b
commit 2ffe258269
5 changed files with 42 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ui/segmented-bar/segmented-bar.android.ts
View File

@ -3,6 +3,7 @@ import common = require("ui/segmented-bar/segmented-bar-common");
import dependencyObservable = require("ui/core/dependency-observable");
import proxy = require("ui/core/proxy");
import types = require("utils/types");
import observable = require("data/observable");
global.moduleMerge(common, exports);
@ -17,13 +18,11 @@ function onSelectedIndexPropertyChanged(data: dependencyObservable.PropertyChang
if (types.isNumber(index)) {
if (index >= 0 && index <= view.items.length - 1) {
view.android.setCurrentTab(index);
view.notify({ eventName: SegmentedBar.selectedIndexChangedEvent, object: view, oldIndex: data.oldValue, newIndex: data.newValue });
} else {
view.selectedIndex = undefined;
throw new Error("selectedIndex should be between [0, items.length - 1]");
}
var args = { eventName: SegmentedBar.selectedIndexChangedEvent, object: view, oldIndex: data.oldValue, newIndex: data.newValue };
view.notify(args);
}
}
(<proxy.PropertyMetadata>common.SegmentedBar.selectedIndexProperty.metadata).onSetNativeValue = onSelectedIndexPropertyChanged;
@ -146,12 +145,7 @@ export class SegmentedBar extends common.SegmentedBar {
onTabChanged: function (id: string) {
var bar = that.get();
if (bar) {
var oldIndex = bar.selectedIndex;
var newIndex = parseInt(id);
if (oldIndex !== newIndex) {
bar._onPropertyChangedFromNative(SegmentedBar.selectedIndexProperty, newIndex);
}
bar.selectedIndex = parseInt(id);
}
}
});