javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): do not call exitEvent on activity restart (#9517)

Browse Source
This commit is contained in:
Eduardo Speroni
2021-08-18 13:09:50 -03:00
committed by GitHub
parent 3a3b505167
commit 2f630dc464
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/ui/frame/index.android.ts
View File

@ -1190,12 +1190,18 @@ class ActivityCallbacksImplementation implements AndroidActivityCallbacks {
rootView._tearDownUI(true); rootView._tearDownUI(true);
} }
// this may happen when the user changes the system theme
// In such case, isFinishing() is false (and isChangingConfigurations is true), and the app will start again (onCreate) with a savedInstanceState
// as a result, launchEvent will never be called
// possible alternative: always fire launchEvent and exitEvent, but pass extra flags to make it clear what kind of launch/destroy is happening
if (activity.isFinishing()) {
const exitArgs = { const exitArgs = {
eventName: application.exitEvent, eventName: application.exitEvent,
object: application.android, object: application.android,
android: activity, android: activity,
}; };
application.notify(exitArgs); application.notify(exitArgs);
}
} finally { } finally {
superFunc.call(activity); superFunc.call(activity);
} }