javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue when bindingContext is bound more than once.

Browse Source
This commit is contained in:
Nedyalko Nikolov
2015-04-30 13:48:52 +03:00
parent 315959a590
commit 2e4b2eacf2
10 changed files with 136 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ui/core/dependency-observable.ts
View File

@@ -23,9 +23,19 @@ function validateRegisterParameters(name: string, ownerType: string) {
}
}
function getPropertyByNameAndType(name: string, ownerType: string): Property {
var key = generatePropertyKey(name, ownerType);
return propertyFromKey[key];
function getPropertyByNameAndType(name: string, owner: any): Property {
var baseClasses = types.getBaseClasses(owner);
var i;
var result;
var key;
for (i = 0; i < baseClasses.length; i++) {
key = generatePropertyKey(name, baseClasses[i]);
result = propertyFromKey[key];
if (result) {
break;
}
}
return result;
}
export module PropertyMetadataSettings {
@@ -254,13 +264,10 @@ export class PropertyEntry implements definition.PropertyEntry {
}
export class DependencyObservable extends observable.Observable {
// TODO: measure the performance of the dictionary vs. JS Object with numeric keys
// private _values = new containers.Dictionary<string, any>(new containers.StringComparer());
private _propertyEntries = {};
public set(name: string, value: any) {
// TODO: Properties must be registered with the correct owner type for this routine to work
var property = getPropertyByNameAndType(name, this.typeName);
var property = getPropertyByNameAndType(name, this);
if (property) {
this._setValue(property, value, ValueSource.Local);
} else {
@@ -269,7 +276,7 @@ export class DependencyObservable extends observable.Observable {
}
public get(name: string): any {
var property = getPropertyByNameAndType(name, this.typeName);
var property = getPropertyByNameAndType(name, this);
if (property) {
return this._getValue(property);
} else {