From 05d776bea8456683405c7d06522c38f7d5c27e9d Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Wed, 16 Dec 2020 10:19:16 +0100 Subject: [PATCH 1/4] chore: fix broken links in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b382cc4f6..3aae9a881 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,11 +9,11 @@ To help the rest of the community review your change, please follow the instruct ## PR Checklist -- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. +- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. - [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. - [ ] You have signed the [CLA](http://www.nativescript.org/cla). -- [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. -- [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md. +- [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. +- [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. ## What is the current behavior? From 61727929cca22ee4df78c9f6955119ef26810768 Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Sat, 19 Dec 2020 10:13:23 -0800 Subject: [PATCH 2/4] ci: enable next tag for master --- .github/workflows/npm_release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/npm_release.yml b/.github/workflows/npm_release.yml index 4264b4363..1f50e99db 100644 --- a/.github/workflows/npm_release.yml +++ b/.github/workflows/npm_release.yml @@ -36,4 +36,4 @@ jobs: run: | echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc echo "Publishing @nativescript/core@$NPM_VERSION to NPM with tag $NPM_TAG..." - npm publish nativescript-core-$NPM_VERSION.tgz --tag $NPM_TAG --dry-run + npm publish nativescript-core-$NPM_VERSION.tgz --tag $NPM_TAG From 0d9350dc800a169255b29e7b86bbe41853cf9b37 Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Sat, 19 Dec 2020 19:35:41 +0100 Subject: [PATCH 3/4] ci: check if npmrc is correct --- .github/workflows/npm_release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/npm_release.yml b/.github/workflows/npm_release.yml index 1f50e99db..6865a5a49 100644 --- a/.github/workflows/npm_release.yml +++ b/.github/workflows/npm_release.yml @@ -35,5 +35,6 @@ jobs: NPM_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }} run: | echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc + cat .npmrc echo "Publishing @nativescript/core@$NPM_VERSION to NPM with tag $NPM_TAG..." npm publish nativescript-core-$NPM_VERSION.tgz --tag $NPM_TAG From 51b383fe85fbef2825e1abdbe9ed73545dda5cc4 Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Sat, 19 Dec 2020 20:14:41 +0100 Subject: [PATCH 4/4] ci: move npmrc to root --- .github/workflows/npm_release.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/npm_release.yml b/.github/workflows/npm_release.yml index 6865a5a49..1e479ab7e 100644 --- a/.github/workflows/npm_release.yml +++ b/.github/workflows/npm_release.yml @@ -6,7 +6,7 @@ on: env: NPM_TAG: 'next' - + jobs: release: runs-on: ubuntu-latest @@ -34,7 +34,6 @@ jobs: env: NPM_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }} run: | - echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc - cat .npmrc + echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ../../.npmrc echo "Publishing @nativescript/core@$NPM_VERSION to NPM with tag $NPM_TAG..." npm publish nativescript-core-$NPM_VERSION.tgz --tag $NPM_TAG