javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed #228: ListPicker for Android shows text after bound to an empty array.

Browse Source
This commit is contained in:
Rossen Hristov
2015-05-28 14:38:13 +03:00
parent 9b0872f068
commit 2b25721829
1 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
ui/list-picker/list-picker.android.ts
View File

@@ -24,6 +24,10 @@ export class ListPicker extends common.ListPicker {
this._android = new android.widget.NumberPicker(this._context); this._android = new android.widget.NumberPicker(this._context);
this._android.setDescendantFocusability(android.widget.NumberPicker.FOCUS_BLOCK_DESCENDANTS); this._android.setDescendantFocusability(android.widget.NumberPicker.FOCUS_BLOCK_DESCENDANTS);
this._android.setMinValue(0);
this._android.setMaxValue(0);
this._android.setValue(0);
var that = new WeakRef(this); var that = new WeakRef(this);
this._formatter = new android.widget.NumberPicker.Formatter({ this._formatter = new android.widget.NumberPicker.Formatter({
@@ -36,7 +40,7 @@ export class ListPicker extends common.ListPicker {
return this.owner._getItemAsString(index); return this.owner._getItemAsString(index);
} }
return ""; return " ";
} }
}); });
this._android.setFormatter(this._formatter); this._android.setFormatter(this._formatter);
@@ -54,50 +58,54 @@ export class ListPicker extends common.ListPicker {
}); });
this._android.setOnValueChangedListener(this._valueChangedListener); this._android.setOnValueChangedListener(this._valueChangedListener);
//Fix disappearing selected item. //Fix the disappearing selected item.
//HACK: http://stackoverflow.com/questions/17708325/android-numberpicker-with-formatter-does-not-format-on-first-rendering/26797732 //HACK: http://stackoverflow.com/questions/17708325/android-numberpicker-with-formatter-does-not-format-on-first-rendering/26797732
var mInputTextField = java.lang.Class.forName("android.widget.NumberPicker").getDeclaredField("mInputText"); var mInputTextField = java.lang.Class.forName("android.widget.NumberPicker").getDeclaredField("mInputText");
mInputTextField.setAccessible(true); mInputTextField.setAccessible(true);
this._editText = <android.widget.EditText>mInputTextField.get(this._android); this._editText = <android.widget.EditText>mInputTextField.get(this._android);
this._editText.setFilters([]); this._editText.setFilters([]);
// Since the Android NumberPicker has to always have at least one item, i.e. minValue=maxValue=value=0, we don't want this zero showing up when this.items is empty. //Since the Android NumberPicker has to always have at least one item, i.e. minValue=maxValue=value=0, we don't want this zero showing up when this.items is empty.
this._editText.setText(" "); this._editText.setText(" ", android.widget.TextView.BufferType.NORMAL);
} }
public _onSelectedIndexPropertyChanged(data: dependencyObservable.PropertyChangeData) { public _onSelectedIndexPropertyChanged(data: dependencyObservable.PropertyChangeData) {
super._onSelectedIndexPropertyChanged(data); super._onSelectedIndexPropertyChanged(data);
if (this.android && types.isNumber(data.newValue)) { if (this.android && types.isNumber(data.newValue)) {
if (types.isDefined(this.items) && types.isNumber(this.items.length)) {
this.android.setMaxValue(this.items.length - 1);
}
this.android.setValue(data.newValue); this.android.setValue(data.newValue);
} }
} }
public _onItemsPropertyChanged(data: dependencyObservable.PropertyChangeData) { public _onItemsPropertyChanged(data: dependencyObservable.PropertyChangeData) {
if (this.android) { if (this.android) {
var maxValue;
if (!data.newValue || !data.newValue.length) { if (!data.newValue || !data.newValue.length) {
maxValue = 0; this.android.setMaxValue(0);
} }
else { else {
maxValue = data.newValue.length - 1; this.android.setMaxValue(data.newValue.length - 1);
} }
this.android.setMaxValue(maxValue);
this.android.setWrapSelectorWheel(false); this.android.setWrapSelectorWheel(false);
} }
this._updateSelectedIndexOnItemsPropertyChanged(data.newValue); this._updateSelectedIndexOnItemsPropertyChanged(data.newValue);
this._fixNumberPickerRendering();
}
private _fixNumberPickerRendering() {
if (!this.android) {
return;
}
//Fix disappearing selected item. //HACK: Force the stubborn NumberPicker to render correctly when we have 0 or 1 items.
//HACK: http://stackoverflow.com/questions/17708325/android-numberpicker-with-formatter-does-not-format-on-first-rendering/26797732 this.android.setFormatter(null);
this.android.setFormatter(this._formatter); //Force the NumberPicker to call our Formatter
if (this._editText) { if (this._editText) {
this._editText.setFilters([]); this._editText.setFilters([]);
} }
this._editText.invalidate(); //Force the EditText to redraw
this.android.invalidate();
} }
} }