javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enums > CoreTypes

Browse Source 
Cleanup type symbol usage by consolidating to manage in one spot. This makes them easier to use as well by providing a single rollup of all the common type symbol's used throughout core.
This commit is contained in:
Nathan Walker
2021-03-15 22:05:47 -07:00
parent e62acba792
commit 21da31562c
106 changed files with 1110 additions and 1128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/ui/scroll-view/scroll-view-common.ts
View File

@@ -5,14 +5,14 @@ import { Property, makeParser, makeValidator } from '../core/properties';
import { CSSType } from '../core/view';
import { booleanConverter } from '../core/view-base';
import { EventData } from '../../data/observable';
import { Enums } from '../enums';
import { CoreTypes } from '../../core-types';
@CSSType('ScrollView')
export abstract class ScrollViewBase extends ContentView implements ScrollViewDefinition {
private _scrollChangeCount = 0;
public static scrollEvent = 'scroll';
public orientation: Enums.OrientationType;
public orientation: CoreTypes.OrientationType;
public scrollBarIndicatorVisible: boolean;
public isScrollEnabled: boolean;
@@ -92,12 +92,12 @@ export interface ScrollViewBase {
on(event: 'scroll', callback: (args: ScrollEventData) => void, thisArg?: any);
}
const converter = makeParser<Enums.OrientationType>(makeValidator(Enums.Orientation.horizontal, Enums.Orientation.vertical));
export const orientationProperty = new Property<ScrollViewBase, Enums.OrientationType>({
const converter = makeParser<CoreTypes.OrientationType>(makeValidator(CoreTypes.Orientation.horizontal, CoreTypes.Orientation.vertical));
export const orientationProperty = new Property<ScrollViewBase, CoreTypes.OrientationType>({
name: 'orientation',
defaultValue: Enums.Orientation.vertical,
defaultValue: CoreTypes.Orientation.vertical,
affectsLayout: true,
valueChanged: (target: ScrollViewBase, oldValue: Enums.OrientationType, newValue: Enums.OrientationType) => {
valueChanged: (target: ScrollViewBase, oldValue: CoreTypes.OrientationType, newValue: CoreTypes.OrientationType) => {
target._onOrientationChanged();
},
valueConverter: converter,