From 20a8beaeb1191eb6272e0e841d67d0ce65db86da Mon Sep 17 00:00:00 2001 From: Eduardo Speroni Date: Sat, 8 May 2021 17:04:12 -0300 Subject: [PATCH] feat: add xml support to all flavors --- packages/webpack5/src/configuration/base.ts | 8 ++++++++ packages/webpack5/src/configuration/javascript.ts | 7 ------- packages/webpack5/src/configuration/typescript.ts | 7 ------- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/packages/webpack5/src/configuration/base.ts b/packages/webpack5/src/configuration/base.ts index 77094da23..ff1a92962 100644 --- a/packages/webpack5/src/configuration/base.ts +++ b/packages/webpack5/src/configuration/base.ts @@ -253,6 +253,14 @@ export default function (config: Config, env: IWebpackEnv = _env): Config { .use('nativescript-worker-loader') .loader('nativescript-worker-loader'); + // config.resolve.extensions.add('.xml'); + // set up xml + config.module + .rule('xml') + .test(/\.xml$/) + .use('xml-namespace-loader') + .loader('xml-namespace-loader'); + // default PostCSS options to use // projects can change settings // via postcss.config.js diff --git a/packages/webpack5/src/configuration/javascript.ts b/packages/webpack5/src/configuration/javascript.ts index ccc821c63..5820734e9 100644 --- a/packages/webpack5/src/configuration/javascript.ts +++ b/packages/webpack5/src/configuration/javascript.ts @@ -25,13 +25,6 @@ export default function (config: Config, env: IWebpackEnv = _env): Config { // config.resolve.extensions.add('.xml'); - // set up xml - config.module - .rule('xml') - .test(/\.xml$/) - .use('xml-namespace-loader') - .loader('xml-namespace-loader'); - // set up core HMR config.module .rule('hmr-core') diff --git a/packages/webpack5/src/configuration/typescript.ts b/packages/webpack5/src/configuration/typescript.ts index cfc4709f5..17ce9b2f6 100644 --- a/packages/webpack5/src/configuration/typescript.ts +++ b/packages/webpack5/src/configuration/typescript.ts @@ -25,13 +25,6 @@ export default function (config: Config, env: IWebpackEnv = _env): Config { // config.resolve.extensions.add('.xml'); - // set up xml - config.module - .rule('xml') - .test(/\.xml$/) - .use('xml-namespace-loader') - .loader('xml-namespace-loader'); - // set up core HMR config.module .rule('hmr-core')