diff --git a/packages/core/ui/transition/fade-transition.ios.ts b/packages/core/ui/transition/fade-transition.ios.ts index f18a19f0e..c7bd355df 100644 --- a/packages/core/ui/transition/fade-transition.ios.ts +++ b/packages/core/ui/transition/fade-transition.ios.ts @@ -12,7 +12,7 @@ export class FadeTransition extends Transition { this.presented = toVC; this.presenting = fromVC; this.operation = operation; - console.log('presenting:', this.presenting); + // console.log('presenting:', this.presenting); return this.transitionController; } } @@ -39,7 +39,7 @@ export class FadeTransitionController extends NSObject implements UIViewControll animateTransition(transitionContext: UIViewControllerContextTransitioning): void { const owner = this.owner.deref(); if (owner) { - console.log('FadeTransitionController animateTransition:', owner.operation); + // console.log('FadeTransitionController animateTransition:', owner.operation); const toView = owner.presented.view; const originalToViewAlpha = toView.alpha; const fromView = owner.presenting.view; diff --git a/packages/core/ui/transition/page-transition.ios.ts b/packages/core/ui/transition/page-transition.ios.ts index 2de0f90d1..fa18e3204 100644 --- a/packages/core/ui/transition/page-transition.ios.ts +++ b/packages/core/ui/transition/page-transition.ios.ts @@ -28,7 +28,7 @@ export class PageTransition extends Transition { this.presenting = fromVC; } this.transitionController = PageTransitionController.initWithOwner(new WeakRef(this)); - console.log('iosNavigatedController presenting:', this.presenting); + // console.log('iosNavigatedController presenting:', this.presenting); this.operation = operation; return this.transitionController; @@ -41,17 +41,17 @@ export class PageTransition extends Transition { } setupInteractiveGesture(startCallback: () => void, view: View): () => void { - console.log(' -- setupInteractiveGesture --'); + // console.log(' -- setupInteractiveGesture --'); this._interactiveStartCallback = startCallback; if (!this._interactiveDismissGesture) { - console.log('setup but tearing down first!'); + // console.log('setup but tearing down first!'); view.off('pan', this._interactiveDismissGesture); this._interactiveDismissGesture = this._interactiveDismissGestureHandler.bind(this); } view.on('pan', this._interactiveDismissGesture); this._interactiveGestureTeardown = () => { - console.log(`-- TEARDOWN setupInteractiveGesture --`); + // console.log(`-- TEARDOWN setupInteractiveGesture --`); view.off('pan', this._interactiveDismissGesture); this._interactiveDismissGesture = null; }; @@ -123,7 +123,7 @@ class PercentInteractiveController extends UIPercentDrivenInteractiveTransition added = false; startInteractiveTransition(transitionContext: UIViewControllerContextTransitioning) { - console.log('startInteractiveTransition'); + // console.log('startInteractiveTransition'); this.transitionContext = transitionContext; if (!this.started) { @@ -252,21 +252,21 @@ class PageTransitionController extends NSObject implements UIViewControllerAnima animateTransition(transitionContext: UIViewControllerContextTransitioning): void { const owner = this.owner.deref(); if (owner) { - console.log('--- PageTransitionController animateTransition'); - console.log('owner.presented:', owner.presented); - console.log('owner.presenting:', owner.presenting); + // console.log('--- PageTransitionController animateTransition'); + // console.log('owner.presented:', owner.presented); + // console.log('owner.presenting:', owner.presenting); // console.log('owner.id:', owner.id); const state = SharedTransition.getState(owner.id); if (!state) { return; } - console.log('state.activeType:', state.activeType); - console.log('operation:', owner.operation); + // console.log('state.activeType:', state.activeType); + // console.log('operation:', owner.operation); // switch (state.activeType) { switch (owner.operation) { case UINavigationControllerOperation.Push: { - console.log('pushing!!'); + // console.log('pushing!!'); // this.presented = toViewCtrl; // this.presenting = fromViewCtrl; @@ -446,7 +446,7 @@ class PageTransitionController extends NSObject implements UIViewControllerAnima break; } case UINavigationControllerOperation.Pop: { - console.log('popping!'); + // console.log('popping!'); transitionContext.containerView.insertSubviewBelowSubview(owner.presenting.view, owner.presented.view); // console.log('transitionContext.containerView.subviews.count:', transitionContext.containerView.subviews.count); diff --git a/packages/core/ui/transition/shared-transition.ts b/packages/core/ui/transition/shared-transition.ts index 4c65b58f2..5074802c9 100644 --- a/packages/core/ui/transition/shared-transition.ts +++ b/packages/core/ui/transition/shared-transition.ts @@ -103,9 +103,9 @@ export class SharedTransition { * @param options * @returns a configured SharedTransition instance for use with navigational APIs. */ - static custom(transition: Transition, options: SharedTransitionConfig): { instance: Transition } { + static custom(transition: Transition, options?: SharedTransitionConfig): { instance: Transition } { SharedTransition.updateState(transition.id, { - ...options, + ...(options || {}), instance: transition, activeType: SharedTransitionAnimationType.present, }); diff --git a/packages/core/ui/transition/slide-transition.ios.ts b/packages/core/ui/transition/slide-transition.ios.ts index 5b9f1d827..ff4648750 100644 --- a/packages/core/ui/transition/slide-transition.ios.ts +++ b/packages/core/ui/transition/slide-transition.ios.ts @@ -44,7 +44,7 @@ export class SlideTransitionController extends NSObject implements UIViewControl } animateTransition(transitionContext: UIViewControllerContextTransitioning): void { - console.log('SlideTransitionController animateTransition'); + // console.log('SlideTransitionController animateTransition'); const owner = this.owner.deref(); if (owner) { const toView = owner.presented.view;