From 6ac1417578f1e4634c6ae8863b4374e15bf4a215 Mon Sep 17 00:00:00 2001 From: Rossen Hristov Date: Mon, 28 Nov 2016 15:13:19 +0200 Subject: [PATCH] Fix: TextView new line closes virtual keyboard on Android Resolves #3111 --- .../ui/editable-text-base/editable-text-base.android.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts b/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts index 9dcfc63a1..eaec3d29a 100644 --- a/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts +++ b/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts @@ -107,7 +107,12 @@ export class EditableTextBase extends common.EditableTextBase { actionId === android.view.inputmethod.EditorInfo.IME_ACTION_SEND || actionId === android.view.inputmethod.EditorInfo.IME_ACTION_NEXT || (event && event.getKeyCode() === android.view.KeyEvent.KEYCODE_ENTER)) { - owner.dismissSoftInput(); + + // If it is TextField, close the keyboard. If it is TextView, do not close it since the TextView is multiline + // https://github.com/NativeScript/NativeScript/issues/3111 + if (textView.getMaxLines() === 1){ + owner.dismissSoftInput(); + } owner._onReturnPress(); } }