javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-18 22:01:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): dont create a borderDrawable if not necessary.

Browse Source 
That action is slow and should be prevented as much as possible
This commit is contained in:
Martin Guillon
2020-12-15 11:37:29 +01:00
parent ee544d7885
commit 1894944b41
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/ui/styling/background.android.ts
View File

@ -44,8 +44,11 @@ export namespace ad {
const constantState = drawable.getConstantState(); const constantState = drawable.getConstantState();
androidView._cachedDrawable = constantState || drawable; androidView._cachedDrawable = constantState || drawable;
} }
const onlyColor = !background.hasBorderWidth() && !background.hasBorderRadius() && !background.clipPath && !background.image && background.color;
if (isSetColorFilterOnlyWidget(nativeView) && drawable && !background.hasBorderWidth() && !background.hasBorderRadius() && !background.clipPath && !background.image && background.color) { if (drawable instanceof android.graphics.drawable.ColorDrawable && onlyColor) {
drawable.setColor(background.color.android);
drawable.invalidateSelf();
} else if (isSetColorFilterOnlyWidget(nativeView) && drawable && onlyColor) {
if (drawable instanceof org.nativescript.widgets.BorderDrawable && androidView._cachedDrawable) { if (drawable instanceof org.nativescript.widgets.BorderDrawable && androidView._cachedDrawable) {
if (!(androidView._cachedDrawable instanceof android.graphics.drawable.Drawable.ConstantState)) { if (!(androidView._cachedDrawable instanceof android.graphics.drawable.Drawable.ConstantState)) {
return; return;