javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): safe important check (#10455)

Browse Source
This commit is contained in:
William Sedlacek
2023-12-19 10:11:10 -08:00
committed by GitHub
parent 4b74b96940
commit 172d3463a3
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/apps_automated.yml vendored
View File

@ -21,12 +21,12 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 18 node-version: 20.10.0
- uses: actions/setup-java@v3 - uses: actions/setup-java@v3
with: with:
distribution: 'temurin' distribution: 'temurin'
java-version: '11' java-version: '17'
- name: Install Python - name: Install Python
uses: actions/setup-python@v4 uses: actions/setup-python@v4
@ -49,6 +49,8 @@ jobs:
- name: Create Emulator - name: Create Emulator
uses: rigor789/action-create-emulator@main uses: rigor789/action-create-emulator@main
with:
package: system-images;android-34;default;x86_64
- name: Test (Android) - name: Test (Android)
run: node tools/scripts/run-automated.js android run: node tools/scripts/run-automated.js android

6
packages/core/ui/styling/css-utils.ts
View File

@ -2,7 +2,11 @@ import { Trace } from '../../trace';
import { CoreTypes } from '../../core-types'; import { CoreTypes } from '../../core-types';
import { Length } from './style-properties'; import { Length } from './style-properties';
export function cleanupImportantFlags(value: string, propertyName: string) { export function cleanupImportantFlags(value: unknown, propertyName: string) {
if (typeof value !== 'string') {
return '' + value;
}
const index = value?.indexOf('!important'); const index = value?.indexOf('!important');
if (index >= 0) { if (index >= 0) {
if (Trace.isEnabled()) { if (Trace.isEnabled()) {

2
tools/scripts/run-automated.js
View File

@ -8,7 +8,7 @@ const spawn = require('child_process').spawn
const kill = require('tree-kill'); const kill = require('tree-kill');
const path = require('path'); const path = require('path');
const TIMEOUT_MS = 5 * 60 * 1000; // 5 minutes const TIMEOUT_MS = 20 * 60 * 1000; // 20 minutes (is Github CI this slow to boot AVDs?)
const workspaceDir = path.resolve(__dirname, '../..'); const workspaceDir = path.resolve(__dirname, '../..');
const platform = process.argv[2]; const platform = process.argv[2];
const spawned_process = spawn( const spawned_process = spawn(