javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 04:41:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Deleteing known folder should resolve as error

Browse Source
This commit is contained in:
vakrilov
2015-03-20 12:13:12 +02:00
parent 50e6068c07
commit 16b9676a2c
3 changed files with 37 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
apps/tests/file-system-tests.ts
View File

@ -565,3 +565,17 @@ export var testKnownFolderRename = function () {
});
}
};
export function testKnownFolderRemove(done) {
var result;
var knownFolder = fs.knownFolders.temp();
knownFolder.remove().then(
function () {
done(new Error("Remove known folder should resolve as error."));
},
function (error) {
done(null);
});
};

25
file-system/file-system-access.android.ts
View File

@ -125,22 +125,27 @@ export class FileSystemAccess {
return;
}
if (isKnown) {
if (onError) {
onError({ message: "Cannot delete known folder." });
}
return;
}
// TODO: Asynchronous
this.deleteFolderContent(javaFile);
if (!isKnown) {
if (javaFile.delete()) {
if (onSuccess) {
onSuccess();
}
} else {
if (onError) {
onError({ message: "Folder deletion failed." });
}
if (javaFile.delete()) {
if (onSuccess) {
onSuccess();
}
} else {
// TODO: Notify error?
if (onError) {
onError({ message: "Folder deletion failed." });
}
}
} catch (exception) {
if (onError) {
onError(exception);

8
file-system/file-system-access.ios.ts
View File

@ -176,6 +176,14 @@ export class FileSystemAccess {
}
public deleteFolder(path: string, isKnown?: boolean, onSuccess?: () => any, onError?: (error: any) => any) {
if (isKnown) {
if (onError) {
onError({ message: "Cannot delete known folder." });
}
return;
}
this.deleteEntity(path, onSuccess, onError);
}