Fix: Deleteing known folder should resolve as error

apps/tests/file-system-tests.ts

@@ -565,3 +565,17 @@ export var testKnownFolderRename = function () {
             });
     }
 };
+
+export function testKnownFolderRemove(done) {
+    var result;
+
+    var knownFolder = fs.knownFolders.temp();
+
+    knownFolder.remove().then(
+        function () {
+            done(new Error("Remove known folder should resolve as error."));
+        },
+        function (error) {
+            done(null);
+        });
+};

file-system/file-system-access.android.ts

@@ -125,10 +125,17 @@ export class FileSystemAccess {
                 return;
             }
 
+            if (isKnown) {
+                if (onError) {
+                    onError({ message: "Cannot delete known folder." });
+                }
+
+                return;
+            }
+
             // TODO: Asynchronous
             this.deleteFolderContent(javaFile);
 
-            if (!isKnown) {
             if (javaFile.delete()) {
                 if (onSuccess) {
                     onSuccess();
@@ -138,9 +145,7 @@ export class FileSystemAccess {
                     onError({ message: "Folder deletion failed." });
                 }
             }
-            } else {
+
-                // TODO: Notify error?
-            }
         } catch (exception) {
             if (onError) {
                 onError(exception);

file-system/file-system-access.ios.ts

@@ -176,6 +176,14 @@ export class FileSystemAccess {
     }
 
     public deleteFolder(path: string, isKnown?: boolean, onSuccess?: () => any, onError?: (error: any) => any) {
+        if (isKnown) {
+            if (onError) {
+                onError({ message: "Cannot delete known folder." });
+            }
+
+            return;
+        }
+
         this.deleteEntity(path, onSuccess, onError);
     }