chore: cleanup

nativescript-core/utils/debug.d.ts

@@ -1,7 +1,3 @@
-/**
- * @module "utils/debug"
- */ /** */
-
 /**
  * A runtime option indicating whether the build has debugging enabled.
  */

nativescript-core/utils/layout-helper/package.json

@@ -1,6 +0,0 @@
-{
-	"name": "layout-helper",
-	"main": "layout-helper",
-	"types": "layout-helper.d.ts",
-	"nativescript": {}
-}

nativescript-core/utils/lazy.d.ts

@@ -1,7 +1,3 @@
-/**
- * @module "utils/lazy"
- */ /** */
-
 /**
  * A function that evaluates the action only once.
  * @param action The action to be evaluated to get the result.

nativescript-core/utils/native-helper.android.ts

@@ -1,8 +1,6 @@
 import { getNativeApplication, android as androidApp } from "../application";
 import {
-    messageType as traceMessageType,
-    categories as traceCategories,
-    write as traceWrite
+    Trace
 } from "../trace";
 
 // We are using "ad" here to avoid namespace collision with the global android object
@@ -145,7 +143,7 @@ export module ad {
                 }
             }
             catch (ex) {
-                traceWrite("Cannot get pallete color: " + name, traceCategories.Error, traceMessageType.error);
+                Trace.write("Cannot get pallete color: " + name, Trace.categories.Error, Trace.messageType.error);
             }
 
             attrCache.set(name, result);

nativescript-core/utils/native-helper.ios.ts

@@ -1,7 +1,5 @@
 import {
-    messageType as traceMessageType,
-    categories as traceCategories,
-    write as traceWrite
+    Trace
 } from "../trace";
 
 declare var UIImagePickerControllerSourceType: any;
@@ -24,7 +22,7 @@ function openFileAtRootModule(filePath: string): boolean {
         return controller.presentPreviewAnimated(true);
     }
     catch (e) {
-        traceWrite("Error in openFile", traceCategories.Error, traceMessageType.error);
+        Trace.write("Error in openFile", Trace.categories.Error, Trace.messageType.error);
     }
 
     return false;

nativescript-core/utils/package.json

@@ -1,3 +0,0 @@
-{
-	"nativescript": {}
-}

nativescript-core/utils/types.d.ts

@@ -1,8 +1,4 @@
 /**
- * @module "utils/types"
- */ /** */
-
-/**
  * A function that checks if something is a valid string.
  * @param value The value which will be checked.
  * Returns true if value is a string.

nativescript-core/utils/utils.android.ts

@@ -2,9 +2,7 @@ import { ad } from "./native-helper";
 import { device } from "../platform";
 import { FileSystemAccess } from "../file-system/file-system-access";
 import {
-    write as traceWrite,
-    categories as traceCategories,
-    messageType as traceMessageType,
+    Trace
 } from "../trace";
 
 export { ad };
@@ -29,7 +27,7 @@ export function openUrl(location: string): boolean {
         context.startActivity(intent);
     } catch (e) {
         // We Don't do anything with an error.  We just output it
-        traceWrite("Error in OpenURL", traceCategories.Error, traceMessageType.error);
+        Trace.write("Error in OpenURL", Trace.categories.Error, Trace.messageType.error);
 
         return false;
     }
@@ -92,13 +90,13 @@ export function openFile(filePath: string): boolean {
     try {
         // Ensure external storage is available
         if (!isExternalStorageAvailable()) {
-            traceWrite(
+            Trace.write(
                 `
 External storage is unavailable (please check app permissions).
 Applications cannot access internal storage of other application on Android (see: https://developer.android.com/guide/topics/data/data-storage).
 `,
-                traceCategories.Error,
-                traceMessageType.error,
+                Trace.categories.Error,
+                Trace.messageType.error,
             );
 
             return false;
@@ -106,7 +104,7 @@ Applications cannot access internal storage of other application on Android (see
 
         // Ensure external storage is available
         if (isExternalStorageReadOnly()) {
-            traceWrite("External storage is read only", traceCategories.Error, traceMessageType.error);
+            Trace.write("External storage is read only", Trace.categories.Error, Trace.messageType.error);
 
             return false;
         }
@@ -122,9 +120,9 @@ Applications cannot access internal storage of other application on Android (see
         // Android SDK <28 only requires starting the chooser Intent straight forwardly
         const sdkVersion = parseInt(device.sdkVersion, 10);
         if (sdkVersion && sdkVersion < MIN_URI_SHARE_RESTRICTED_APK_VERSION) {
-            traceWrite(
+            Trace.write(
                 `detected sdk version ${sdkVersion} (< ${MIN_URI_SHARE_RESTRICTED_APK_VERSION}), using simple openFile`,
-                traceCategories.Debug
+                Trace.categories.Debug
             );
             intent.setDataAndType(android.net.Uri.fromFile(new java.io.File(filePath)), mimeType);
             context.startActivity(chooserIntent);
@@ -132,9 +130,9 @@ Applications cannot access internal storage of other application on Android (see
             return true;
         }
 
-        traceWrite(
+        Trace.write(
             `detected sdk version ${sdkVersion} (>= ${MIN_URI_SHARE_RESTRICTED_APK_VERSION}), using URI openFile`,
-            traceCategories.Debug
+            Trace.categories.Debug
         );
 
         // Android SDK 24+ introduced file system permissions changes that disallow
@@ -143,7 +141,7 @@ Applications cannot access internal storage of other application on Android (see
         // see: https://developer.android.com/reference/android/os/FileUriExposedException
         // see: https://github.com/NativeScript/NativeScript/issues/5661#issuecomment-456405380
         const providerName = `${context.getPackageName()}.provider`;
-        traceWrite(`fully-qualified provider name [${providerName}]`, traceCategories.Debug);
+        Trace.write(`fully-qualified provider name [${providerName}]`, Trace.categories.Debug);
 
         const apkURI = androidx.core.content.FileProvider.getUriForFile(
             context,
@@ -163,19 +161,19 @@ Applications cannot access internal storage of other application on Android (see
         return true;
     } catch (err) {
         const msg = err.message ? `: ${err.message}` : "";
-        traceWrite(`Error in openFile${msg}`, traceCategories.Error, traceMessageType.error);
+        Trace.write(`Error in openFile${msg}`, Trace.categories.Error, Trace.messageType.error);
 
         if (msg &&
             msg.includes("Attempt to invoke virtual method") &&
             msg.includes("android.content.pm.ProviderInfo.loadXmlMetaData") &&
             msg.includes("on a null object reference")) {
             // Alert user to possible fix
-            traceWrite(
+            Trace.write(
                 `
 Please ensure you have your manifest correctly configured with the FileProvider.
 (see: https://developer.android.com/reference/android/support/v4/content/FileProvider#ProviderDefinition)
 `,
-                traceCategories.Error,
+                Trace.categories.Error,
             );
         }
 

nativescript-core/utils/utils.d.ts

@@ -1,7 +1,3 @@
-/**
- * @module "utils/utils"
- */ /** */
-
 import { dip, px } from "../ui/core/view";
 
 export * from "./mainthread-helper"

nativescript-core/utils/utils.ios.ts

@@ -1,6 +1,6 @@
 import { ios } from "./native-helper";
 import {
-    write as traceWrite, categories as traceCategories, messageType as traceMessageType
+    Trace
 } from "../trace";
 
 export { ios };
@@ -17,7 +17,7 @@ export function openFile(filePath: string): boolean {
         return controller.presentPreviewAnimated(true);
     }
     catch (e) {
-        traceWrite("Error in openFile", traceCategories.Error, traceMessageType.error);
+        Trace.write("Error in openFile", Trace.categories.Error, Trace.messageType.error);
     }
 
     return false;
@@ -40,7 +40,7 @@ export function openUrl(location: string): boolean {
     }
     catch (e) {
         // We Don't do anything with an error.  We just output it
-        traceWrite("Error in OpenURL", traceCategories.Error, traceMessageType.error);
+        Trace.write("Error in OpenURL", Trace.categories.Error, Trace.messageType.error);
     }
 
     return false;