javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 03:31:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(xhr): remove unnecessary throw when event not supported (#9251)

Browse Source 
closes https://github.com/NativeScript/NativeScript/issues/9245
This commit is contained in:
Nathan Walker
2021-02-26 14:33:59 -08:00
committed by GitHub
parent c8ef6f2ab3
commit 11ef943495
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/core/xhr/index.ts
View File

@ -1,5 +1,6 @@
import * as http from '../http'; import * as http from '../http';
import * as types from '../utils/types'; import * as types from '../utils/types';
import { Trace } from '../trace';
namespace XMLHttpRequestResponseType { namespace XMLHttpRequestResponseType {
export const empty = ''; export const empty = '';
@ -170,7 +171,9 @@ export class XMLHttpRequest {
public addEventListener(eventName: string, handler: Function) { public addEventListener(eventName: string, handler: Function) {
if (['abort', 'error', 'load', 'loadend', 'loadstart', 'progress', 'readystatechange'].indexOf(eventName) === -1) { if (['abort', 'error', 'load', 'loadend', 'loadstart', 'progress', 'readystatechange'].indexOf(eventName) === -1) {
throw new Error('Event not supported: ' + eventName); if (Trace.isEnabled()) {
Trace.write('XHR Event not supported: ' + eventName, Trace.categories.Debug, Trace.messageType.warn);
}
} }
const handlers = this._listeners.get(eventName) || []; const handlers = this._listeners.get(eventName) || [];