javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in action-bar for android. (#2854)

Browse Source
This commit is contained in:
Hristo Hristov
2016-10-07 13:02:58 +03:00
committed by GitHub
parent edc9e483a9
commit 109ac26c5b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tns-core-modules/ui/action-bar/action-bar.android.ts
View File

@@ -194,7 +194,7 @@ export class ActionBar extends common.ActionBar {
} }
public _updateNavigationButton() { public _updateNavigationButton() {
var navButton = this.navigationButton; let navButton = this.navigationButton;
if (navButton && common.isVisible(navButton)) { if (navButton && common.isVisible(navButton)) {
if (navButton.android.systemIcon) { if (navButton.android.systemIcon) {
// Try to look in the system resources. // Try to look in the system resources.
@@ -208,10 +208,12 @@ export class ActionBar extends common.ActionBar {
this._toolbar.setNavigationIcon(drawableOrId); this._toolbar.setNavigationIcon(drawableOrId);
} }
let navBtn = new WeakRef(navButton);
this._toolbar.setNavigationOnClickListener(new android.view.View.OnClickListener({ this._toolbar.setNavigationOnClickListener(new android.view.View.OnClickListener({
onClick: function (v) { onClick: function (v) {
if (navButton) { let owner = navBtn.get();
navButton._raiseTap(); if (owner) {
owner._raiseTap();
} }
} }
})); }));