javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 11:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove critical circular dependencies (#8114)

Browse Source 
* chore: remove critical circular dependencies

* chore: fix tslint errors

* chore: remove platform specific types from interfaces

* chore: update unit tests polyfills

* fix: incorrect null check

* chore: update api.md file

* test: improve test case

* chore: apply comments

* test: avoid page style leaks in tests
This commit is contained in:
Martin Yankov
2019-11-28 13:36:34 +02:00
committed by Alexander Vakrilov
parent 5b647bd809
commit 0ffc790d82
72 changed files with 1958 additions and 1307 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
nativescript-core/debugger/devtools-elements-interfaces.ts Normal file
View File

@ -0,0 +1,18 @@
//Types
import { DOMNode } from "./dom-node";
export interface InspectorCommands {
// DevTools -> Application communication. Methods that devtools calls when needed.
getDocument(): string | DOMNode;
removeNode(nodeId: number): void;
getComputedStylesForNode(nodeId: number): string | Array<{ name: string, value: string }>;
setAttributeAsText(nodeId: number, text: string, name: string): void;
}
export interface InspectorEvents {
// Application -> DevTools communication. Methods that the app should call when needed.
childNodeInserted(parentId: number, lastId: number, node: DOMNode): void;
childNodeRemoved(parentId: number, nodeId: number): void;
attributeModified(nodeId: number, attrName: string, attrValue: string): void;
attributeRemoved(nodeId: number, attrName: string): void;
}

7
nativescript-core/debugger/devtools-elements.android.ts
View File

@ -1,7 +1,12 @@
import { InspectorEvents, InspectorCommands } from "./devtools-elements";
// Types
import { InspectorEvents, InspectorCommands } from "./devtools-elements-interfaces";
// Requires
import { getDocument, getComputedStylesForNode, removeNode, setAttributeAsText } from "./devtools-elements.common";
import { registerInspectorEvents, DOMNode } from "./dom-node";
export * from "./devtools-elements-interfaces";
export function attachDOMInspectorEventCallbacks(DOMDomainFrontend: InspectorEvents) {
registerInspectorEvents(DOMDomainFrontend);

7
nativescript-core/debugger/devtools-elements.common.ts
View File

@ -1,7 +1,8 @@
import { getNodeById } from "./dom-node";
// Needed for typings only
// Types
import { ViewBase } from "../ui/core/view-base";
//Requires
import { getNodeById } from "./dom-node";
import { mainThreadify } from "../utils/utils";
// Use lazy requires for core modules

7
nativescript-core/debugger/devtools-elements.ios.ts
View File

@ -1,7 +1,12 @@
import { InspectorEvents, InspectorCommands } from "./devtools-elements";
// Types
import { InspectorEvents, InspectorCommands } from "./devtools-elements-interfaces";
// Requires
import { getDocument, getComputedStylesForNode, removeNode, setAttributeAsText } from "./devtools-elements.common";
import { registerInspectorEvents, DOMNode } from "./dom-node";
export * from "./devtools-elements-interfaces";
export function attachDOMInspectorEventCallbacks(DOMDomainFrontend: InspectorEvents) {
registerInspectorEvents(DOMDomainFrontend);

2
nativescript-core/debugger/dom-node.ts
View File

@ -1,5 +1,5 @@
import { CSSComputedStyleProperty } from "./css-agent";
import { InspectorEvents } from "./devtools-elements";
import { InspectorEvents } from "./devtools-elements-interfaces";
// Needed for typings only
import { ViewBase } from "../ui/core/view";