From 0ef4a37c3b48c55518e0836e48e711556a47ab17 Mon Sep 17 00:00:00 2001
From: Martin Guillon <martin.guillon@akylas.fr>
Date: Tue, 5 Jan 2021 16:11:04 +0100
Subject: [PATCH] chore: rename variable per comments

---
 packages/core/global-types.d.ts                | 2 +-
 packages/core/ui/core/bindable/index.ts        | 8 ++++----
 packages/core/ui/list-view/list-view-common.ts | 2 +-
 packages/core/ui/repeater/index.ts             | 2 +-
 packages/webpack5/src/configuration/base.ts    | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/core/global-types.d.ts b/packages/core/global-types.d.ts
index 517dcc480..dfbaf689e 100644
--- a/packages/core/global-types.d.ts
+++ b/packages/core/global-types.d.ts
@@ -131,7 +131,7 @@ declare namespace NodeJS {
 declare const __DEV__: string;
 declare const __CSS_PARSER__: string;
 declare const __NS_WEBPACK__: boolean;
-declare const __UI_CUSTOM_FLAVOR__: boolean;
+declare const __UI_USE_EXTERNAL_RENDERER__: boolean;
 declare const __UI_USE_XML_PARSER__: boolean;
 declare const __ANDROID__: boolean;
 declare const __IOS__: boolean;
diff --git a/packages/core/ui/core/bindable/index.ts b/packages/core/ui/core/bindable/index.ts
index a7fbe1b7c..0033603ca 100644
--- a/packages/core/ui/core/bindable/index.ts
+++ b/packages/core/ui/core/bindable/index.ts
@@ -344,7 +344,7 @@ export class Binding {
 		}
 
 		let newValue = value;
-		if (__UI_CUSTOM_FLAVOR__) {
+		if (__UI_USE_EXTERNAL_RENDERER__) {
 		} else if (this.options.expression) {
 			const changedModel = {};
 			changedModel[bc.bindingValueKey] = value;
@@ -376,7 +376,7 @@ export class Binding {
 	}
 
 	private _getExpressionValue(expression: string, isBackConvert: boolean, changedModel: any): any {
-		if (!__UI_CUSTOM_FLAVOR__) {
+		if (!__UI_USE_EXTERNAL_RENDERER__) {
 			try {
 				const exp = PolymerExpressions.getExpression(expression);
 				if (exp) {
@@ -426,7 +426,7 @@ export class Binding {
 			}
 		}
 
-		if (__UI_CUSTOM_FLAVOR__ || !this.options.expression) {
+		if (__UI_USE_EXTERNAL_RENDERER__ || !this.options.expression) {
 			if (changedPropertyIndex > -1) {
 				const props = sourceProps.slice(changedPropertyIndex + 1);
 				const propsLength = props.length;
@@ -521,7 +521,7 @@ export class Binding {
 	}
 
 	private getSourcePropertyValue() {
-		if (__UI_CUSTOM_FLAVOR__) {
+		if (__UI_USE_EXTERNAL_RENDERER__) {
 		} else if (this.options.expression) {
 			const changedModel = {};
 			changedModel[bc.bindingValueKey] = this.source ? this.source.get() : undefined;
diff --git a/packages/core/ui/list-view/list-view-common.ts b/packages/core/ui/list-view/list-view-common.ts
index 8e5a875a9..ce1e88f43 100644
--- a/packages/core/ui/list-view/list-view-common.ts
+++ b/packages/core/ui/list-view/list-view-common.ts
@@ -26,7 +26,7 @@ export abstract class ListViewBase extends ContainerView implements ListViewDefi
 	public _defaultTemplate: KeyedTemplate = {
 		key: 'default',
 		createView: () => {
-			if (__UI_CUSTOM_FLAVOR__) {
+			if (__UI_USE_EXTERNAL_RENDERER__) {
 			} else if (this.itemTemplate) {
 				return Builder.parse(this.itemTemplate, this);
 			}
diff --git a/packages/core/ui/repeater/index.ts b/packages/core/ui/repeater/index.ts
index 630f0be50..5a3d1c5e3 100644
--- a/packages/core/ui/repeater/index.ts
+++ b/packages/core/ui/repeater/index.ts
@@ -129,7 +129,7 @@ export class Repeater extends CustomLayoutView {
 			}
 
 			if (!viewToAdd) {
-				if (__UI_CUSTOM_FLAVOR__) {
+				if (__UI_USE_EXTERNAL_RENDERER__) {
 					viewToAdd = this._getDefaultItemContent(i)
 				} else {
 					viewToAdd = this.itemTemplate ? Builder.parse(this.itemTemplate, this) : this._getDefaultItemContent(i);
diff --git a/packages/webpack5/src/configuration/base.ts b/packages/webpack5/src/configuration/base.ts
index 02a1bad00..160838bbe 100644
--- a/packages/webpack5/src/configuration/base.ts
+++ b/packages/webpack5/src/configuration/base.ts
@@ -243,7 +243,7 @@ export default function (config: Config, env: IWebpackEnv): Config {
 			__DEV__: mode === 'development',
 			__NS_WEBPACK__: true,
 			__UI_USE_XML_PARSER__: true,
-			__UI_CUSTOM_FLAVOR__: projectUsesCustomFlavor(),
+			__UI_USE_EXTERNAL_RENDERER__: projectUsesCustomFlavor(),
 			__CSS_PARSER__: JSON.stringify(getValue('cssParser')), // todo: replace from config value
 			__ANDROID__: platform === 'android',
 			__IOS__: platform === 'ios',