chore: combine prettier with eslint (#9348) (#9360)

Co-authored-by: Martin Guillon <martin.guillon@akylas.fr>

.eslintrc.json

@@ -1,10 +1,14 @@
 {
+	"extends": ["plugin:prettier/recommended"],
 	"parser": "@typescript-eslint/parser",
 	"parserOptions": {
+		"ecmaVersion": 2018,
 		"sourceType": "module",
-		"ecmaVersion": 2015
+		"parser": "@typescript-eslint/parser",
+		"project": "tsconfig.eslint.json",
+		"warnOnUnsupportedTypeScriptVersion": false
 	},
-	"plugins": ["@nativescript"],
+	"plugins": ["prettier", "@nativescript"],
 	"rules": {
 		"@nativescript/no-nativescript-angular-imports": "warn",
 		"@nativescript/no-tns-core-modules-imports": "warn",

packages/core/.eslintrc.json

@@ -1,7 +1,7 @@
 {
-	"extends": "../../.eslintrc",
+	"extends": "../../.eslintrc.json",
 	"rules": {},
-	"ignorePatterns": ["!**/*"],
+	"ignorePatterns": ["!**/*", "**/node_modules/**/*", "**/__tests__/**/*"],
 	"overrides": [
 		{
 			"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],

packages/core/accessibility/index.ios.ts

@@ -222,7 +222,6 @@ export function updateAccessibilityProperties(view: View): void {
 	uiView.accessibilityTraits = a11yTraits;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
 export const sendAccessibilityEvent = (): void => {};
 export const updateContentDescription = (): string | null => null;
 

packages/core/application/index.android.ts

@@ -4,7 +4,6 @@ import { AndroidActivityBackPressedEventData, AndroidActivityBundleEventData, An
 
 // TODO: explain why we need to this or remov it
 // Use requires to ensure order of imports is maintained
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const appCommon = require('./application-common');
 
 // First reexport so that app module is initialized.

packages/core/application/index.ios.ts

@@ -4,7 +4,6 @@ import { ApplicationEventData, CssChangedEventData, LaunchEventData, LoadAppCSSE
 
 // TODO: explain why we need to this or remov it
 // Use requires to ensure order of imports is maintained
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const { displayedEvent, exitEvent, getCssFileName, launchEvent, livesync, lowMemoryEvent, notify, on, orientationChanged, orientationChangedEvent, resumeEvent, setApplication, suspendEvent, systemAppearanceChanged, systemAppearanceChangedEvent } = require('./application-common');
 // First reexport so that app module is initialized.
 export * from './application-common';

packages/core/config/config.interface.ts

@@ -12,7 +12,6 @@ interface IConfigPlatform {
 	discardUncaughtJsExceptions?: boolean;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 interface IConfigIOS extends IConfigPlatform {}
 
 interface IConfigAndroid extends IConfigPlatform {

packages/core/connectivity/index.android.ts

@@ -30,7 +30,6 @@ function getActiveNetworkInfo(): android.net.NetworkInfo {
 }
 
 function getNetworkCapabilities() {
-	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 	// @ts-ignore
 	const connectivityManager: any = getConnectivityManager();
 	const network = connectivityManager.getActiveNetwork();
@@ -39,7 +38,6 @@ function getNetworkCapabilities() {
 		return connectionType.none;
 	}
 
-	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 	// @ts-ignore
 	const NetworkCapabilities = (android as any).net.NetworkCapabilities;
 
@@ -101,13 +99,11 @@ export function getConnectionType(): number {
 }
 
 function startMonitoringLegacy(connectionTypeChangedCallback) {
-	// eslint-disable-next-line @typescript-eslint/no-unused-vars
 	const onReceiveCallback = function onReceiveCallback(context: android.content.Context, intent: android.content.Intent) {
 		const newConnectionType = getConnectionType();
 		connectionTypeChangedCallback(newConnectionType);
 	};
 	const zoneCallback = zonedCallback(onReceiveCallback);
-	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 	// @ts-ignore
 	androidApp.registerBroadcastReceiver(android.net.ConnectivityManager.CONNECTIVITY_ACTION, zoneCallback);
 }
@@ -129,21 +125,18 @@ export function startMonitoring(connectionTypeChangedCallback: (newConnectionTyp
 			if (!networkCallback) {
 				@NativeClass
 				class NetworkCallbackImpl extends ConnectivityManager.NetworkCallback {
-					// eslint-disable-next-line @typescript-eslint/no-unused-vars
 					onAvailable(network: android.net.Network) {
 						if (notifyCallback) {
 							notifyCallback();
 						}
 					}
 
-					// eslint-disable-next-line @typescript-eslint/no-unused-vars
 					onCapabilitiesChanged(network: android.net.Network, networkCapabilities: android.net.NetworkCapabilities) {
 						if (notifyCallback) {
 							notifyCallback();
 						}
 					}
 
-					// eslint-disable-next-line @typescript-eslint/no-unused-vars
 					onLost(network) {
 						if (notifyCallback) {
 							notifyCallback();
@@ -169,7 +162,6 @@ export function startMonitoring(connectionTypeChangedCallback: (newConnectionTyp
 
 export function stopMonitoring(): void {
 	if (android.os.Build.VERSION.SDK_INT >= 28) {
-		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 		// @ts-ignore
 		const manager = getConnectivityManager();
 		if (manager && callback) {

packages/core/debugger/devtools-elements.common.ts

@@ -6,13 +6,11 @@ import { getNodeById } from './dom-node';
 import { mainThreadify } from '../utils';
 
 // Use lazy requires for core modules
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const getAppRootView = () => require('../application').getRootView();
 
 let unsetValue;
 function unsetViewValue(view, name) {
 	if (!unsetValue) {
-		// eslint-disable-next-line @typescript-eslint/no-var-requires
 		unsetValue = require('../ui/core/properties').unsetValue;
 	}
 

packages/core/debugger/dom-node.ts

@@ -14,11 +14,8 @@ function lazy<T>(action: () => T): () => T {
 
 	return () => _value || (_value = action());
 }
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const percentLengthToStringLazy = lazy<(length) => string>(() => require('../ui/styling/style-properties').PercentLength.convertToString);
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const getSetPropertiesLazy = lazy<(view: ViewBase) => [string, any][]>(() => require('../ui/core/properties').getSetProperties);
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const getComputedCssValuesLazy = lazy<(view: ViewBase) => [string, any][]>(() => require('../ui/core/properties').getComputedCssValues);
 
 export function registerInspectorEvents(inspector: InspectorEvents) {

packages/core/debugger/webinspector-css.ios.ts

@@ -1,5 +1,4 @@
 import * as inspectorCommandTypes from './InspectorBackendCommands.ios';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const inspectorCommands: typeof inspectorCommandTypes = require('./InspectorBackendCommands');
 
 import * as debuggerDomains from '.';

packages/core/debugger/webinspector-dom.ios.ts

@@ -1,5 +1,4 @@
 import * as inspectorCommandTypes from './InspectorBackendCommands.ios';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const inspectorCommands: typeof inspectorCommandTypes = require('./InspectorBackendCommands');
 
 import * as debuggerDomains from '.';

packages/core/debugger/webinspector-network.ios.ts

@@ -1,5 +1,4 @@
 import * as inspectorCommandTypes from './InspectorBackendCommands.ios';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const inspectorCommands: typeof inspectorCommandTypes = require('./InspectorBackendCommands');
 
 import * as debuggerDomains from '.';

packages/core/globals/index.ts

@@ -1,5 +1,4 @@
 import * as tslibType from 'tslib';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const tslib: typeof tslibType = require('tslib');
 import { Observable } from '../data/observable';
 import { trace as profilingTrace, time, uptime, level as profilingLevel } from '../profiling';

packages/core/profiling/index.ts

@@ -160,7 +160,6 @@ export function enable(mode: InstrumentationMode = 'counters') {
 }
 
 try {
-	// eslint-disable-next-line @typescript-eslint/no-var-requires
 	const appConfig = require('~/package.json');
 	if (appConfig && appConfig.profiling) {
 		enable(appConfig.profiling);

packages/core/ui/builder/component-builder/index.ts

@@ -95,7 +95,6 @@ const createComponentInstance = profile('createComponentInstance', (elementName:
 		// Create instance of the component.
 		instance = new instanceType();
 	} catch (ex) {
-		// eslint-disable-next-line @typescript-eslint/no-var-requires
 		const debug: typeof debugModule = require('../../../utils/debug');
 		throw new debug.ScopeError(ex, "Module '" + (resolvedModuleName || elementName) + "' not found for element '" + (namespace ? namespace + ':' : '') + elementName + "'.");
 	}

packages/core/ui/core/bindable/index.ts

@@ -10,7 +10,6 @@ import { escapeRegexSymbols } from '../../../utils';
 import { Trace } from '../../../trace';
 import * as types from '../../../utils/types';
 import * as bindableResources from './bindable-resources';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const polymerExpressions = require('../../../js-libs/polymer-expressions');
 import { PolymerExpressions } from '../../../js-libs/polymer-expressions';
 

packages/core/ui/date-picker/date-picker-common.ts

@@ -67,4 +67,4 @@ export const iosPreferredDatePickerStyleProperty = new Property<DatePickerBase,
 	defaultValue: 0,
 	valueConverter: (v) => parseInt(v),
 });
-iosPreferredDatePickerStyleProperty.register(DatePickerBase);
+iosPreferredDatePickerStyleProperty.register(DatePickerBase);

packages/core/ui/dialogs/dialogs-common.ts

@@ -268,7 +268,6 @@ let textField: View;
 
 export function getButtonColors(): { color: Color; backgroundColor: Color } {
 	if (!button) {
-		// eslint-disable-next-line @typescript-eslint/no-var-requires
 		const Button = require('../button').Button;
 		button = new Button();
 		if (global.isIOS) {
@@ -288,7 +287,6 @@ export function getButtonColors(): { color: Color; backgroundColor: Color } {
 
 export function getLabelColor(): Color {
 	if (!label) {
-		// eslint-disable-next-line @typescript-eslint/no-var-requires
 		const Label = require('../label').Label;
 		label = new Label();
 		if (global.isIOS) {
@@ -306,7 +304,6 @@ export function getLabelColor(): Color {
 
 export function getTextFieldColor(): Color {
 	if (!textField) {
-		// eslint-disable-next-line @typescript-eslint/no-var-requires
 		const TextField = require('../text-field').TextField;
 		textField = new TextField();
 		if (global.isIOS) {

packages/core/ui/frame/activity.android.ts

@@ -1,6 +1,5 @@
 import '../../globals';
 import { setActivityCallbacks, AndroidActivityCallbacks } from '.';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const appModule = require('../../application');
 
 /**

packages/core/ui/frame/frame-common.ts

@@ -289,7 +289,6 @@ export class FrameBase extends CustomLayoutView {
 	}
 
 	private isNestedWithin(parentFrameCandidate: FrameBase): boolean {
-		// eslint-disable-next-line @typescript-eslint/no-this-alias
 		let frameAncestor: FrameBase = this;
 		while (frameAncestor) {
 			frameAncestor = <FrameBase>getAncestor(frameAncestor, FrameBase);

packages/core/ui/frame/index.android.ts

@@ -39,7 +39,6 @@ let fragmentId = -1;
 export let moduleLoaded: boolean;
 
 if (global && global.__inspector) {
-	// eslint-disable-next-line @typescript-eslint/no-var-requires
 	const devtools = require('../../debugger/devtools-elements');
 	devtools.attachDOMInspectorEventCallbacks(global.__inspector);
 	devtools.attachDOMInspectorCommandCallbacks(global.__inspector);

packages/core/ui/styling/style-scope.ts

@@ -33,7 +33,6 @@ function ensureCssAnimationParserModule() {
 
 let parser: 'rework' | 'nativescript' | 'css-tree' = 'css-tree';
 try {
-	// eslint-disable-next-line @typescript-eslint/no-var-requires
 	const appConfig = require('~/package.json');
 	if (appConfig) {
 		if (appConfig.cssParser === 'rework') {

packages/core/ui/time-picker/index.d.ts

@@ -77,4 +77,4 @@ export const minMinuteProperty: Property<TimePicker, number>;
 export const timeProperty: Property<TimePicker, Date>;
 export const minuteIntervalProperty: Property<TimePicker, number>;
 
-export const iosPreferredDatePickerStyleProperty: Property<TimePicker, number>;
+export const iosPreferredDatePickerStyleProperty: Property<TimePicker, number>;

packages/core/xml/index.ts

@@ -2,7 +2,6 @@
 // https://github.com/NativeScript/nativescript-dev-webpack/issues/932
 
 import * as definition from '.';
-// eslint-disable-next-line @typescript-eslint/no-var-requires
 const easysax = require('../js-libs/easysax');
 import { EasySAXParser } from '../js-libs/easysax';
 

tsconfig.eslint.json

@@ -0,0 +1,4 @@
+{
+	"extends": "./tsconfig.json",
+	"include": ["packages/**/*"]
+}