javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-14 18:12:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(testing): e2e flag no longer needed, testID is now applicable in dev or prod builds (#10396)

Browse Source 
- you can now test on development or production with testID set
- for android, this changes testID to use resource id instead of content description
- you no longer need to pass `--env.e2e`. e2e is simply usable if testID is set
- the `testID` property will also set `accessibilityIdentifier` and `accessibilityIdentifier` property will set `testID` only if there is a `testID` already set
This commit is contained in:
Canmert
2023-10-04 18:49:26 +03:00
committed by GitHub
parent 757af1430e
commit 0a2b2202f3
16 changed files with 40 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/webpack5/__tests__/configuration/__snapshots__/angular.spec.ts.snap
View File

@ -367,8 +367,7 @@ exports[`angular configuration for android 1`] = `
'global.isAndroid': true,
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */
@ -800,8 +799,7 @@ exports[`angular configuration for ios 1`] = `
'global.isAndroid': false,
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */

6
packages/webpack5/__tests__/configuration/__snapshots__/base.spec.ts.snap
View File

@ -269,8 +269,7 @@ exports[`base configuration for android 1`] = `
'global.isAndroid': true,
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */
@ -597,8 +596,7 @@ exports[`base configuration for ios 1`] = `
'global.isAndroid': false,
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */

6
packages/webpack5/__tests__/configuration/__snapshots__/javascript.spec.ts.snap
View File

@ -269,8 +269,7 @@ exports[`javascript configuration for android 1`] = `
'global.isAndroid': true,
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */
@ -596,8 +595,7 @@ exports[`javascript configuration for ios 1`] = `
'global.isAndroid': false,
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */

4
packages/webpack5/__tests__/configuration/__snapshots__/react.spec.ts.snap
View File

@ -292,7 +292,6 @@ exports[`react configuration > android > adds ReactRefreshWebpackPlugin when HMR
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false,
__TEST__: false,
'process.env.NODE_ENV': '"development"'
}
@ -631,7 +630,6 @@ exports[`react configuration > android > base config 1`] = `
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false,
__TEST__: false,
'process.env.NODE_ENV': '"development"'
}
@ -977,7 +975,6 @@ exports[`react configuration > ios > adds ReactRefreshWebpackPlugin when HMR ena
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false,
__TEST__: false,
'process.env.NODE_ENV': '"development"'
}
@ -1317,7 +1314,6 @@ exports[`react configuration > ios > base config 1`] = `
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false,
__TEST__: false,
'process.env.NODE_ENV': '"development"'
}

6
packages/webpack5/__tests__/configuration/__snapshots__/svelte.spec.ts.snap
View File

@ -296,8 +296,7 @@ exports[`svelte configuration for android 1`] = `
'global.isAndroid': true,
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */
@ -645,8 +644,7 @@ exports[`svelte configuration for ios 1`] = `
'global.isAndroid': false,
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */

6
packages/webpack5/__tests__/configuration/__snapshots__/typescript.spec.ts.snap
View File

@ -269,8 +269,7 @@ exports[`typescript configuration for android 1`] = `
'global.isAndroid': true,
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */
@ -596,8 +595,7 @@ exports[`typescript configuration for ios 1`] = `
'global.isAndroid': false,
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */

6
packages/webpack5/__tests__/configuration/__snapshots__/vue.spec.ts.snap
View File

@ -309,8 +309,7 @@ exports[`vue configuration for android 1`] = `
'global.isAndroid': true,
'global.isIOS': false,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */
@ -671,8 +670,7 @@ exports[`vue configuration for ios 1`] = `
'global.isAndroid': false,
'global.isIOS': true,
'global.isVisionOS': false,
process: 'global.process',
__USE_TEST_ID__: false
process: 'global.process'
}
),
/* config.plugin('CopyWebpackPlugin') */

3
packages/webpack5/src/configuration/base.ts
View File

@ -449,9 +449,6 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
/* for compat only */ 'global.isVisionOS': platform === 'visionos',
process: 'global.process',
// enable testID when using --env.e2e
__USE_TEST_ID__: !!env.e2e,
// todo: ?!?!
// profile: '() => {}',
},

1
packages/webpack5/src/index.ts
View File

@ -52,7 +52,6 @@ export interface IWebpackEnv {
// misc
replace?: string[] | string;
watchNodeModules?: boolean;
e2e?: boolean;
}
interface IChainEntry {