javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 11:01:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(hermes): wrap registerOnGlobalContext() in try-catch

Browse Source
This commit is contained in:
shirakaba
2023-12-02 11:47:00 +09:00
parent e04e9b6909
commit 054f63bd3b
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
packages/core/globals/index.ts
View File

@ -15,23 +15,27 @@ interface ExtensionMap {
} }
function registerOnGlobalContext(moduleName: string, exportName: string): void { function registerOnGlobalContext(moduleName: string, exportName: string): void {
Object.defineProperty(global, exportName, { try {
get: function () { Object.defineProperty(global, exportName, {
// We do not need to cache require() call since it is already cached in the runtime. get: function () {
const m = global.loadModule(moduleName); // We do not need to cache require() call since it is already cached in the runtime.
const m = global.loadModule(moduleName);
// Redefine the property to make sure the above code is executed only once. // Redefine the property to make sure the above code is executed only once.
const resolvedValue = m[exportName]; const resolvedValue = m[exportName];
Object.defineProperty(global, exportName, { Object.defineProperty(global, exportName, {
value: resolvedValue, value: resolvedValue,
configurable: true, configurable: true,
writable: true, writable: true,
}); });
return resolvedValue; return resolvedValue;
}, },
configurable: true, configurable: true,
}); });
} catch (_e) {
// TODO: On Hermes, some globals are non-configurable and we cannot override them.
}
} }
/** /**