javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 19:26:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(hermes): wrap registerOnGlobalContext() in try-catch

Browse Source
This commit is contained in:
shirakaba
2023-12-02 11:47:00 +09:00
parent e04e9b6909
commit 054f63bd3b
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/globals/index.ts
View File

@ -15,6 +15,7 @@ interface ExtensionMap {
} }
function registerOnGlobalContext(moduleName: string, exportName: string): void { function registerOnGlobalContext(moduleName: string, exportName: string): void {
try {
Object.defineProperty(global, exportName, { Object.defineProperty(global, exportName, {
get: function () { get: function () {
// We do not need to cache require() call since it is already cached in the runtime. // We do not need to cache require() call since it is already cached in the runtime.
@ -32,6 +33,9 @@ function registerOnGlobalContext(moduleName: string, exportName: string): void {
}, },
configurable: true, configurable: true,
}); });
} catch (_e) {
// TODO: On Hermes, some globals are non-configurable and we cannot override them.
}
} }
/** /**