javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 04:41:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1133 from NativeScript/time-picker-max-hour

Browse Source 
Time picker max hour fixed
This commit is contained in:
Vladimir Enchev
2015-11-23 11:43:43 +02:00
parent 95f7061962 efb7fa3e92
commit 03e69cbf85
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/tests/ui/time-picker/time-picker-tests.ts
View File

@ -76,11 +76,11 @@ export function test_WhenCreated_MinHourIs1() {
});
}
export function test_WhenCreated_MaxHourIs23() {
export function test_WhenCreated_MaxHourIs24() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var actualValue = timePicker.maxHour;
var expectedValue = 23;
var expectedValue = 24;
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}

4
ui/time-picker/time-picker-common.ts
View File

@ -5,7 +5,7 @@ import view = require("ui/core/view");
import types = require("utils/types");
function isHourValid(value: number): boolean {
return types.isNumber(value) && value >= 1 && value <= 23;
return types.isNumber(value) && value >= 1 && value <= 24;
}
function isMinuteValid(value: number): boolean {
@ -48,7 +48,7 @@ export class TimePicker extends view.View implements definition.TimePicker {
new proxy.PropertyMetadata(1, dependencyObservable.PropertyMetadataSettings.None, undefined, isHourValid));
public static maxHourProperty = new dependencyObservable.Property("maxHour", "TimePicker",
new proxy.PropertyMetadata(23, dependencyObservable.PropertyMetadataSettings.None, undefined, isHourValid));
new proxy.PropertyMetadata(24, dependencyObservable.PropertyMetadataSettings.None, undefined, isHourValid));
public static minuteProperty = new dependencyObservable.Property("minute", "TimePicker",
new proxy.PropertyMetadata(undefined, dependencyObservable.PropertyMetadataSettings.None, undefined, isMinuteValid));