From 86055354b8da94140ff64f17e79df21286a4f5df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Morten=20Anton=20Bach=20Sj=C3=B8gren?= Date: Thu, 1 Sep 2016 16:17:46 +0200 Subject: [PATCH 1/2] Feature: automationText wasn't read aloud on iOS. View.automationText on iOS now sets both accessibilityIdentifier and accessibilityLabel --- tns-core-modules/ui/core/view.ios.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/tns-core-modules/ui/core/view.ios.ts b/tns-core-modules/ui/core/view.ios.ts index d42239b97..a02d05873 100644 --- a/tns-core-modules/ui/core/view.ios.ts +++ b/tns-core-modules/ui/core/view.ios.ts @@ -21,6 +21,7 @@ global.moduleMerge(viewCommon, exports); function onAutomationTextPropertyChanged(data: dependencyObservable.PropertyChangeData) { var view = data.object; view._nativeView.accessibilityIdentifier = data.newValue; + view._nativeView.accessibilityLabel = data.newValue; } (viewCommon.View.automationTextProperty.metadata).onSetNativeValue = onAutomationTextPropertyChanged; From a8013fbbe16b2ccde8ad6d56f4f223be9931f938 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Morten=20Anton=20Bach=20Sj=C3=B8gren?= Date: Mon, 5 Sep 2016 10:38:08 +0200 Subject: [PATCH 2/2] Feature: automationText wasn't read aloud on iOS. Updates iOS-test to check for both accessibilityLabel and accessibilityIdentifier values on the NativeElement --- tests/app/ui/view/view-tests.ios.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/app/ui/view/view-tests.ios.ts b/tests/app/ui/view/view-tests.ios.ts index 4b60dd0e3..1bad900e9 100644 --- a/tests/app/ui/view/view-tests.ios.ts +++ b/tests/app/ui/view/view-tests.ios.ts @@ -79,4 +79,5 @@ export function test_automation_text_set_to_native() { var newButton = new button.Button(); newButton.automationText = "Button1"; TKUnit.assertEqual((newButton.ios).accessibilityIdentifier, "Button1", "accessibilityIdentifier not set to native view."); -} \ No newline at end of file + TKUnit.assertEqual((newButton.ios).accessibilityLabel, "Button1", "accessibilityIdentifier not set to native view."); +}