java/ruoyi-vue-pro
1
0
Fork 0
mirror of https://github.com/YunaiV/ruoyi-vue-pro.git synced 2025-11-04 08:06:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

!1246 【性能优化】循环中减少不必要的查询 update r/yudao/module/promotion/service/coupon/CouponServiceImpl.java.

Browse Source 
Merge pull request !1246 from 山野羡民/N/A
This commit is contained in:
芋道源码
2025-02-22 09:42:57 +00:00
committed by Gitee
parent 3c10dcf392 12170402e2
commit 2a9dffb6ed
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
yudao-module-mall/yudao-module-promotion-biz/src/main/java/cn/iocoder/yudao/module/promotion/service/coupon/CouponServiceImpl.java
View File

@ -121,6 +121,10 @@ public class CouponServiceImpl implements CouponService {
@Transactional(rollbackFor = Exception.class)
public Map<Long, List<Long>> takeCoupon(Long templateId, Set<Long> userIds, CouponTakeTypeEnum takeType) {
CouponTemplateDO template = couponTemplateService.getCouponTemplate(templateId);
return takeCoupon(template, userIds, takeType);
}
private Map<Long, List<Long>> takeCoupon(CouponTemplateDO template, Set<Long> userIds, CouponTakeTypeEnum takeType) {
// 1. 过滤掉达到领取限制的用户
removeTakeLimitUser(userIds, template);
// 2. 校验优惠劵是否可以领取
@ -131,7 +135,7 @@ public class CouponServiceImpl implements CouponService {
couponMapper.insertBatch(couponList);
// 4. 增加优惠劵模板的领取数量
couponTemplateService.updateCouponTemplateTakeCount(templateId, userIds.size());
couponTemplateService.updateCouponTemplateTakeCount(template.getId(), userIds.size());
return convertMultiMap(couponList, CouponDO::getUserId, CouponDO::getId);
}
@ -208,7 +212,7 @@ public class CouponServiceImpl implements CouponService {
public void takeCouponByRegister(Long userId) {
List<CouponTemplateDO> templates = couponTemplateService.getCouponTemplateListByTakeType(CouponTakeTypeEnum.REGISTER);
for (CouponTemplateDO template : templates) {
takeCoupon(template.getId(), CollUtil.newHashSet(userId), CouponTakeTypeEnum.REGISTER);
takeCoupon(template, CollUtil.newHashSet(userId), CouponTakeTypeEnum.REGISTER);
}
}