12 Commits

Author SHA1 Message Date
a0066fcf54 Fix all golangci-lint warnings surfaced by v2.4.0 (#4567)
* Initial plan

* Fix all golangci-lint warnings (21 issues resolved)

Co-authored-by: gabek <414923+gabek@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: gabek <414923+gabek@users.noreply.github.com>
2025-09-25 20:03:40 -07:00
cd874cda93 Use subtle.ConstantTimeCompare instead of simple string compare. Closes #2489 2022-12-23 21:26:55 -08:00
f0a11cac5d Optimise regexp usage (#1502)
* Optimise regexp usage

* Revert regexp removal

* Atleast use the semioptimised version
2021-10-29 12:29:01 -07:00
fae2c58259 Fix rtmp secret validation to allow / (#1069) (#1070)
* Fix rtmp secret validation to allow `/` (#1069)

* add negative test cases for stuff before /live/

* simplify since Url.Path is already stripping the host

This means that we can simplify the code and make it much clearer.
Removes the tests that checked for the host and stuff between the host and /live/.
2021-06-04 20:09:43 -07:00
1fe1c6c925 Move duplicate string to a constant 2020-12-16 23:01:09 -08:00
b405b2fcc7 Connections from Restream seem to be more sensitive about if we get the initial packets processed or not, so I moved setStreamAsConnected to be decoupled from when we set broadcaster info. Another update for #432 2020-12-06 14:28:00 -08:00
2abea78e3c Use onMetaData instead of setDataFrame to try to parse out RTMP
metadata. Closes #419
2020-12-05 18:37:42 -08:00
0b66f3b79f Support video-only streams if there is no audio in the inbound stream. (#401)
Closes #400
2020-12-02 00:19:55 -08:00
a40b3a0e80 Check if inbound details properly set before use (#365)
* Check if inbound details properly set before use

Fixes #340

* Only parse setDataFrame messages

* Remove unneeded guard
2020-11-16 20:14:22 -08:00
4d2066a76d Start cleaning up linter errors. (#358)
* Start cleaning up linter errors. For #357

* Fix unmarshalling NullTime values

* More linter fixes

* Remove commented code

* Move defer up

* Consolidate error check lines

* Move error check to make sure row iteration was successful

* Cleaner error check + do not recreate pipe if it exists

* Consolidate hashing to generate client id
2020-11-14 18:39:53 -08:00
769fc3a561 Fixes #211: Update mod paths (#221)
Co-authored-by: Michael Leow <mleow@moneylion.com>
2020-10-05 10:07:09 -07:00
f4fdc6c951 Current broadcaster details admin api (#206)
* Add support for ending the inbound stream. Closes #191

* Add a simple success response to API requests

* Store inbound broadcast details for admin purposes

* Add /api/admin/broadcaster endpoint

* Reset broadcaster on disconnect

* Move controller to admin directory
2020-10-02 00:12:47 -07:00