golang/owncast
1
0
Fork 0
mirror of https://github.com/owncast/owncast.git synced 2025-11-02 20:23:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add pluralization support to Translation component (#4441)

Browse Source 
* Initial plan

* Add pluralization support to Translation component with comprehensive tests

Co-authored-by: gabek <414923+gabek@users.noreply.github.com>

* Javascript formatting autofixes

* Update web/tests/translation.test.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update web/components/ui/Translation/Translation.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: linter warning

* Simplify pluralization logic: use original key for plural, only _one for singular

Co-authored-by: gabek <414923+gabek@users.noreply.github.com>

* feat(i18n): fix support for nested namespace string and key extraction

* chore: update extracted translations

* fix(i18n): fix linter warnings in extraction script

* Update web/scripts/i18n-extract.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat(i18n): sort translation keys

* fix(i18n): fix linter warnings

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: gabek <414923+gabek@users.noreply.github.com>
Co-authored-by: Owncast <owncast@owncast.online>
Co-authored-by: Gabe Kangas <gabek@real-ity.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Copilot
2025-07-13 17:34:06 -07:00
committed by GitHub
parent 1fd86fa190
commit 59b905649e
9 changed files with 392 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
web/scripts/i18n-extract.js
View File

@ -14,14 +14,28 @@ function getDotPath(node) {
const prop = node.property.name || node.property.value;
if (objectPath !== null && prop) {
return objectPath ? `${objectPath}.${prop}` : prop; // skip base if empty
return objectPath ? `${objectPath}.${prop}` : prop;
}
} else if (node.type === 'Identifier' && node.name === 'Localization') {
return ''; // treat as base, skip
return '';
}
return null;
}
function sortObjectKeys(obj) {
if (Array.isArray(obj)) {
return obj.map(sortObjectKeys);
}
if (obj !== null && typeof obj === 'object') {
return Object.keys(obj)
.sort()
.reduce((acc, key) => ({ ...acc, [key]: sortObjectKeys(obj[key]) }), {});
}
return obj;
}
function scanTranslationKeys() {
const files = glob.sync('**/*.{ts,tsx,js,jsx}', {
ignore: ['node_modules/**', '.next/**', 'out/**'],
@ -77,8 +91,14 @@ function scanTranslationKeys() {
}
}
if (key && defaultText && !results[key]) {
results[key] = defaultText;
if (key) {
// Eventually enable this to not allow empty strings.
// Then remove the 'missing translation' fallback below.
// if (!defaultText || defaultText.trim() === '') {
// process.exit(1);
// }
results[key] =
defaultText || `<strong><em>Missing translation ${key}: Please report</em></strong>`;
}
},
});
@ -87,7 +107,37 @@ function scanTranslationKeys() {
return results;
}
function updateTranslationFile(newTranslations) {
// Recursively sets a nested value using a dot-notated key
function setNestedKey(obj, keyPath, value) {
const keys = keyPath.split('.');
let current = obj;
keys.forEach((key, index) => {
if (index === keys.length - 1) {
current[key] = value;
} else {
if (!current[key] || typeof current[key] !== 'object') {
current[key] = {};
}
current = current[key];
}
});
}
// Deep merge of two objects
function mergeDeep(target, source) {
const output = { ...target };
for (const key of Object.keys(source)) {
if (source[key] && typeof source[key] === 'object' && !Array.isArray(source[key])) {
output[key] = mergeDeep(output[key] || {}, source[key]);
} else {
output[key] = source[key];
}
}
return output;
}
function updateTranslationFile(flatTranslations) {
let existing = {};
if (fs.existsSync(TRANSLATIONS_PATH)) {
@ -95,20 +145,26 @@ function updateTranslationFile(newTranslations) {
}
let changed = false;
let newNestedTranslations = {};
for (const [key, value] of Object.entries(newTranslations)) {
if (!(key in existing)) {
existing[key] = value;
for (const [flatKey, value] of Object.entries(flatTranslations)) {
const tempObj = {};
setNestedKey(tempObj, flatKey, value);
// Detect if this key is already present
const flatKeyParts = flatKey.split('.');
const alreadyExists = flatKeyParts.reduce((acc, part) => acc && acc[part], existing);
if (!alreadyExists) {
newNestedTranslations = mergeDeep(newNestedTranslations, tempObj);
changed = true;
console.log(`[i18n] Added: ${key}`);
console.log(`[i18n] Added: ${flatKey}`);
}
}
if (changed) {
const sorted = Object.fromEntries(
Object.entries(existing).sort(([a], [b]) => a.localeCompare(b)),
);
fs.writeFileSync(TRANSLATIONS_PATH, JSON.stringify(sorted, null, 2));
const merged = sortObjectKeys(mergeDeep(existing, newNestedTranslations));
fs.writeFileSync(TRANSLATIONS_PATH, JSON.stringify(merged, null, 2));
console.log(`[i18n] Updated ${TRANSLATIONS_PATH}`);
} else {
console.log('[i18n] No new keys to add.');