execute webhooks in parallel (and 🐛 update webhooks.last_used correctly) (#1505)

*  execute webhooks in parallel

* 🐛 update the webhooks.last_used column correctly
This commit is contained in:
Jannik
2021-11-02 03:13:20 +01:00
committed by GitHub
parent 3fdae7afb9
commit 2278fec70a
2 changed files with 18 additions and 14 deletions

View File

@ -36,20 +36,22 @@ func SendEventToWebhooks(payload WebhookEvent) {
webhooks := data.GetWebhooksForEvent(payload.Type)
for _, webhook := range webhooks {
log.Debugf("Event %s sent to Webhook %s", payload.Type, webhook.URL)
if err := sendWebhook(webhook.URL, payload); err != nil {
log.Errorf("Event: %s failed to send to webhook: %s Error: %s", payload.Type, webhook.URL, err)
}
go func(webhook models.Webhook, payload WebhookEvent) {
log.Debugf("Event %s sent to Webhook %s", payload.Type, webhook.URL)
if err := sendWebhook(webhook, payload); err != nil {
log.Errorf("Event: %s failed to send to webhook: %s Error: %s", payload.Type, webhook.URL, err)
}
}(webhook, payload)
}
}
func sendWebhook(url string, payload WebhookEvent) error {
func sendWebhook(webhook models.Webhook, payload WebhookEvent) error {
jsonText, err := json.Marshal(payload)
if err != nil {
return err
}
req, err := http.NewRequest("POST", url, bytes.NewReader(jsonText))
req, err := http.NewRequest("POST", webhook.URL, bytes.NewReader(jsonText))
if err != nil {
return err
}
@ -65,7 +67,7 @@ func sendWebhook(url string, payload WebhookEvent) error {
defer resp.Body.Close()
if err := data.SetWebhookAsUsed(url); err != nil {
if err := data.SetWebhookAsUsed(webhook); err != nil {
log.Warnln(err)
}