mirror of
https://github.com/go-delve/delve.git
synced 2025-10-27 20:23:41 +08:00
79cc19a7a4
We've always said that predefined breakpoints (like the unrecovered-panic breakpoint) are just like any other breakpoint and clients can remove them by using the ClearBreakpoint API. However commit 78471b3a in 2022 made this not true by treating negative IDs (which is what we assign to predefined breakpoints) specially. That change was made as part of a series of changes to support debugging child processes: prior to that change breakpoints were cleared by address only (which worked fine for predefined breakpoints) but this was not tenable for multiprocess debugging. So ClearBreakpoint was changed to clear breakpoints by breakpoint ID and only use address in a backward compatibility mode when no ID was specified. The current implementation of ClearBreakpoint works fine for user breakpoints in all cases and for predefined breakpoints as long as there is only one target process (clearing a predefined breakpoint will be processed in backwards compatibility mode using its address). However it should be possible to clear predefined breakpoints even when Delve is attached to multiple processes. For this reason limit the backwards compatibility mode of ClearBreakpoint to only ID == 0, sparing negative IDs as valid.