golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-01 12:01:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: removed dead code from proc.(*Variable).parseG

Browse Source
This commit is contained in:
aarzilli
2016-03-23 13:40:17 +01:00
parent 487215fd09
commit d735d1824c
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
proc/variables.go
View File

@ -341,16 +341,13 @@ func (gvar *Variable) parseG() (*G, error) {
gaddr := uint64(gvar.Addr) gaddr := uint64(gvar.Addr)
_, deref := gvar.RealType.(*dwarf.PtrType) _, deref := gvar.RealType.(*dwarf.PtrType)
initialInstructions := make([]byte, dbp.arch.PtrSize()+1)
initialInstructions[0] = op.DW_OP_addr
binary.LittleEndian.PutUint64(initialInstructions[1:], gaddr)
if deref { if deref {
gaddrbytes, err := mem.readMemory(uintptr(gaddr), dbp.arch.PtrSize()) gaddrbytes, err := mem.readMemory(uintptr(gaddr), dbp.arch.PtrSize())
if err != nil { if err != nil {
return nil, fmt.Errorf("error derefing *G %s", err) return nil, fmt.Errorf("error derefing *G %s", err)
} }
initialInstructions = append([]byte{op.DW_OP_addr}, gaddrbytes...)
gaddr = binary.LittleEndian.Uint64(gaddrbytes) gaddr = binary.LittleEndian.Uint64(gaddrbytes)
}
if gaddr == 0 { if gaddr == 0 {
id := 0 id := 0
if thread, ok := mem.(*Thread); ok { if thread, ok := mem.(*Thread); ok {
@ -358,10 +355,6 @@ func (gvar *Variable) parseG() (*G, error) {
} }
return nil, NoGError{ tid: id } return nil, NoGError{ tid: id }
} }
}
if gaddr == 0 {
return nil, NoGError{}
}
gvar.loadValue() gvar.loadValue()
if gvar.Unreadable != nil { if gvar.Unreadable != nil {
return nil, gvar.Unreadable return nil, gvar.Unreadable