golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-29 17:56:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: Always pass ldflags to builds on OSX

Browse Source 
Previously, 'ldflags' were added to the compiler invocation based on the
version of Go the user was running. It seems to make more sense to
simply always pass along the flags on Darwin (due to the bug mentioned
in the comment above this line in the diff) as that is less brittle than
branching on the Go version, and yet will not break current users /
developers work flow.
This commit is contained in:
Derek Parker
2015-09-25 17:19:09 -07:00
parent 5ba0435382
commit c91ca831b7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -9,7 +9,7 @@ GOVERSION=$(shell go version)
# will be malformed once we codesign it and # will be malformed once we codesign it and
# unable to execute. # unable to execute.
# See https://github.com/golang/go/issues/11887#issuecomment-126117692. # See https://github.com/golang/go/issues/11887#issuecomment-126117692.
ifneq (,$(findstring 1.5, $(GOVERSION))) ifeq "$(UNAME)" "Darwin"
FLAGS=-ldflags="-s" FLAGS=-ldflags="-s"
endif endif