golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-03 05:47:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup stopTheWorld arity

Browse Source
This commit is contained in:
Derek Parker
2014-11-23 10:44:28 -06:00
parent 5254c5188e
commit c4eadc386b
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
proctl/proctl_linux_amd64.go
View File

@ -441,14 +441,14 @@ func handleBreakPoint(dbp *DebuggedProcess, pid int) error {
return err return err
} }
} }
stopTheWorld(dbp, thread, pid) stopTheWorld(dbp)
return nil return nil
} }
// Check to see if we have hit a user set breakpoint. // Check to see if we have hit a user set breakpoint.
if bp, ok := dbp.BreakPoints[pc-1]; ok { if bp, ok := dbp.BreakPoints[pc-1]; ok {
if !bp.temp { if !bp.temp {
stopTheWorld(dbp, thread, pid) stopTheWorld(dbp)
} }
return nil return nil
} }
@ -456,18 +456,13 @@ func handleBreakPoint(dbp *DebuggedProcess, pid int) error {
return fmt.Errorf("did not hit recognized breakpoint") return fmt.Errorf("did not hit recognized breakpoint")
} }
func stopTheWorld(dbp *DebuggedProcess, thread *ThreadContext, pid int) error { func stopTheWorld(dbp *DebuggedProcess) error {
// Loop through all threads and ensure that we // Loop through all threads and ensure that we
// stop the rest of them, so that by the time // stop the rest of them, so that by the time
// we return control to the user, all threads // we return control to the user, all threads
// are inactive. We send SIGSTOP and ensure all // are inactive. We send SIGSTOP and ensure all
// threads are in in signal-delivery-stop mode. // threads are in in signal-delivery-stop mode.
for _, th := range dbp.Threads { for _, th := range dbp.Threads {
if th.Id == pid {
// This thread is already stopped.
continue
}
ps, err := parseProcessStatus(th.Id) ps, err := parseProcessStatus(th.Id)
if err != nil { if err != nil {
return err return err