golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-10-27 12:05:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: remove proc.Process.Kill

Browse Source 
the proper way to kill the target process is to pass true to Detach.
Everything except old test code did that already.
This commit is contained in:
aarzilli
2018-02-13 15:42:14 +01:00
committed by Derek Parker
parent f32ce1b21d
commit ac1aa98378
9 changed files with 13 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/proc/proc_unix_test.go
View File

@ -46,7 +46,7 @@ func TestIssue419(t *testing.T) {
if p.Pid() <= 0 {
// if we don't stop the inferior the test will never finish
p.RequestManualStop()
err := p.Kill()
err := p.Detach(true)
errChan <- errIssue419{pid: p.Pid(), err: err}
return
}
@ -57,7 +57,7 @@ func TestIssue419(t *testing.T) {
errChan <- proc.Continue(p)
})
for i :=0; i<2; i++ {
for i := 0; i < 2; i++ {
err := <-errChan
if v, ok := err.(errIssue419); ok {