golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-02 21:40:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

proc: do not always allocate struct literals (#3953)

Browse Source 
Do not always allocate new struct literals to the target's memroy. Wait
until they actually need to have an address.

Fixes #1465
This commit is contained in:
Alessandro Arzilli
2025-03-24 18:24:49 +01:00
committed by GitHub
parent d15845eb91
commit a80904ca1f
5 changed files with 118 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/proc/variables_test.go
View File

@ -669,6 +669,9 @@ func getEvalExpressionTestCases() []varTest {
{"mnil[\"Malone\"]", false, "", "", "", errors.New("key not found")},
{"m1[80:]", false, "", "", "", errors.New("map index out of bounds")},
{"mlarge", false, "map[main.largestruct]main.largestruct [{name: \"one\", v: [256]uint8 [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,...+192 more]}: {name: \"oneval\", v: [256]uint8 [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,...+192 more]}, ]", "map[main.largestruct]main.largestruct [...]", "map[main.largestruct]main.largestruct", nil},
{"m3[main.astruct{1,1}]", false, "42", "42", "int", nil},
{"m4[main.astruct{2,2}]", false, "main.astruct {A: 22, B: 22}", "main.astruct {A: 22, B: 22}", "main.astruct", nil},
{"m3[main.astruct{3,3}]", false, "", "", "", errors.New("key not found")},
// interfaces
{"err1", true, "error(*main.astruct) *{A: 1, B: 2}", "error(*main.astruct) 0x…", "error", nil},
@ -982,6 +985,12 @@ func TestEvalExpression(t *testing.T) {
// this type of eval is unsupported with the current version of Go.
return
}
if err != nil && err.Error() == "expression *ast.CompositeLit not implemented" {
if !goversion.VersionAfterOrEqual(runtime.Version(), 1, 23) || runtime.GOARCH == "386" {
// composite literals not supported before 1.22
return
}
}
if tc.err == nil {
assertNoError(err, t, fmt.Sprintf("EvalExpression(%s) returned an error", tc.name))
assertVariable(t, variable, tc)
@ -1403,11 +1412,11 @@ func TestCallFunction(t *testing.T) {
}
var testcases123 = []testCaseCallFunction{
{`mul2(main.a2struct{Y: 3})`, []string{":int:6"}, nil, 1},
{`mul2(main.a2struct{4})`, []string{":int:8"}, nil, 1},
{`mul2(main.a2struct{Y: 3})`, []string{":int:6"}, nil, 0},
{`mul2(main.a2struct{4})`, []string{":int:8"}, nil, 0},
{`mul2ptr(&main.a2struct{Y: 3})`, []string{":int:6"}, nil, 1},
{`mul2ptr(&main.a2struct{1})`, []string{":int:2"}, nil, 1},
{`m[main.intpair{3, 1}]`, []string{`:string:"three,one"`}, nil, 1},
{`m[main.intpair{3, 1}]`, []string{`:string:"three,one"`}, nil, 0},
}
withTestProcessArgs("fncall", t, ".", nil, protest.AllNonOptimized, func(p *proc.Target, grp *proc.TargetGroup, fixture protest.Fixture) {