golang/delve
1
0
Fork 0
mirror of https://github.com/go-delve/delve.git synced 2025-11-04 14:36:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: split read* into seperate functions

Browse Source
This commit is contained in:
Derek Parker
2014-08-04 13:25:00 -05:00
parent 2b83a1f3ca
commit a22d563252
1 changed files with 26 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
proctl/proctl_linux_amd64.go
View File

@ -373,9 +373,19 @@ func (dbp *DebuggedProcess) extractValue(instructions []byte, typ interface{}) (
return "", err return "", err
} }
offset := uintptr(int64(regs.Rsp) + off)
switch typ.(type) { switch typ.(type) {
case *dwarf.IntType: case *dwarf.IntType:
addr := uintptr(int64(regs.Rsp) + off) return dbp.readInt(offset)
case *dwarf.FloatType:
return dbp.readFloat64(offset)
}
return "", fmt.Errorf("could not find value for type %s", typ)
}
func (dbp *DebuggedProcess) readInt(addr uintptr) (string, error) {
val, err := dbp.readMemory(addr, 8) val, err := dbp.readMemory(addr, 8)
if err != nil { if err != nil {
return "", err return "", err
@ -384,9 +394,9 @@ func (dbp *DebuggedProcess) extractValue(instructions []byte, typ interface{}) (
n := binary.LittleEndian.Uint64(val) n := binary.LittleEndian.Uint64(val)
return strconv.Itoa(int(n)), nil return strconv.Itoa(int(n)), nil
case *dwarf.FloatType: }
func (dbp *DebuggedProcess) readFloat64(addr uintptr) (string, error) {
var n float64 var n float64
addr := uintptr(int64(regs.Rsp) + off)
val, err := dbp.readMemory(addr, 8) val, err := dbp.readMemory(addr, 8)
if err != nil { if err != nil {
return "", err return "", err
@ -395,9 +405,6 @@ func (dbp *DebuggedProcess) extractValue(instructions []byte, typ interface{}) (
binary.Read(buf, binary.LittleEndian, &n) binary.Read(buf, binary.LittleEndian, &n)
return strconv.FormatFloat(n, 'f', -1, 64), nil return strconv.FormatFloat(n, 'f', -1, 64), nil
}
return "", fmt.Errorf("could not find value for type %s", typ)
} }
func (dbp *DebuggedProcess) readMemory(addr uintptr, size uintptr) ([]byte, error) { func (dbp *DebuggedProcess) readMemory(addr uintptr, size uintptr) ([]byte, error) {