From 7dc93a40833bc1fb15563d0e60bdd9bb7d02b075 Mon Sep 17 00:00:00 2001 From: Derek Parker Date: Wed, 28 May 2014 17:47:29 -0500 Subject: [PATCH] Fix: string formatting bug in Clear() --- proctl/proctl_linux_amd64.go | 2 +- proctl/proctl_test.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/proctl/proctl_linux_amd64.go b/proctl/proctl_linux_amd64.go index 8b8a5ea6..a2fa8290 100644 --- a/proctl/proctl_linux_amd64.go +++ b/proctl/proctl_linux_amd64.go @@ -137,7 +137,7 @@ func (dbp *DebuggedProcess) Clear(pc uint64) (*BreakPoint, error) { return nil, err } - delete(dbp.BreakPoints, fmt.Sprintf("s:%d", bp.File, bp.Line)) + delete(dbp.BreakPoints, fmt.Sprintf("%s:%d", bp.File, bp.Line)) return bp, nil } diff --git a/proctl/proctl_test.go b/proctl/proctl_test.go index 4d8ef62a..9836b4c7 100644 --- a/proctl/proctl_test.go +++ b/proctl/proctl_test.go @@ -216,4 +216,8 @@ func TestClearBreakPoint(t *testing.T) { if bytes.Equal(data, int3) { t.Fatalf("Breakpoint was not cleared data: %#v, int3: %#v", data, int3) } + + if len(p.BreakPoints) != 0 { + t.Fatal("Breakpoint not removed internally") + } }